Skip host verification on loopback interface #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the Dashboards API reverse proxy interface communicates via the loopback interface we can safely skip host verification. Avoids receiving a 502 response when the server cert does not list localhost. Fixes #1748 Signed-off-by: James Phillips <jamesdphillips@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
As the Dashboard's API reverse proxy communicates via the loopback
interface we can safely skip host verification. Avoids receiving a 502
response when the server cert does not list localhost.
Why is this change necessary?
Fixes #1748.
Does your change need a Changelog entry?
Yes.
Do you need clarification on anything?
No.
Were there any complications while making this change?
Replicating the issue was frustrating.
Have you reviewed and updated the documentation for this change? Is new documentation required?
n/a