Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sensiolabs/GotenbergBundle
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.2.0
Choose a base ref
...
head repository: sensiolabs/GotenbergBundle
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.3.0
Choose a head ref
  • 11 commits
  • 84 files changed
  • 5 contributors

Commits on Nov 19, 2024

  1. Configuration menu
    Copy the full SHA
    bbdfaeb View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Configuration menu
    Copy the full SHA
    7d86472 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ee33766 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2025

  1. fix: generate doc case (#133)

    Co-authored-by: rhyd42 <rhydian.roberts@chinasearch.co.uk>
    Jean-Beru and rhyd42 authored Jan 7, 2025
    Configuration menu
    Copy the full SHA
    884eb43 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2025

  1. [RELEASE_8.15.0] Add split feature (#132)

    * [RELEASE_8.15.0] Add split feature
    StevenRenaux authored Jan 8, 2025
    Configuration menu
    Copy the full SHA
    7f1e8e9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    72473ec View commit details
    Browse the repository at this point in the history
  3. [Docs] Add CONTRIBUTING.md (#129)

    * [Docs] Add CONTRIBUTING.md
    smnandre authored Jan 8, 2025
    Configuration menu
    Copy the full SHA
    fad1e81 View commit details
    Browse the repository at this point in the history
  4. Add GotenbergAssetRuntime to avoid passing Builder in context (#128)

    * Add `GotenbergAssetRuntime` to avoid passing Builder in context
    
    Passing builder in context is fragile, as it won't work if user
    uses any of Twig layout features without passing the full context.
    
    Starting with Twig 4.0, the `include` function won't pass the
    full context, to encourage template isolation and composition.
    
    This PR introduce a Twig Runtime, lowering the impact of this extension
    on the global scope, and allowing to create a time-limited "scope",
    during which the `gotenberg_asset` will work as expected.
    smnandre authored Jan 8, 2025
    Configuration menu
    Copy the full SHA
    044847c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d646c12 View commit details
    Browse the repository at this point in the history
  6. Use Path:: methods instead of Filesystem instance (#127)

    * Use Path:: methods instead of Filesystem instance
    
    `Filesystem->isAbsolutePath` does not check if the file exists and just make quick checks on the string.
    
    So here the Path utility methods seem a better choice as they are platform-agnostic and allow safe operations like `::join`  handle `../../` in paths and handle full path canonicalization.
    
    And the tests can be done on any strings, independently on the Fixtures files here.
    
    I think this method is used before calling `new File()`, so maybe the whole thing could be replaced by some factory/provider returning an Asset or something like that?
    
    * Make 'sensiolabs_gotenberg.asset.base_dir_formatter' private
    smnandre authored Jan 8, 2025
    Configuration menu
    Copy the full SHA
    70a9e28 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9a5c76a View commit details
    Browse the repository at this point in the history
Loading