-
Notifications
You must be signed in to change notification settings - Fork 729
feat: geolocation setter in sendgrid-python for GDPR compliance #1073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1dc2b2d to
1e1299d
Compare
9c2ff65 to
b81337d
Compare
2d070ea to
4780178
Compare
4780178 to
6ceb524
Compare
shrutiburman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@tbischel, What will be the precedence of the host and data_residency.
Can you please clarify if this is correct precedence? |
gladysmae08
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR
639f14e to
3dc77d8
Compare
|
regarding precedence: |
|
Makes sense Tyler, thanks. |
|
@tbischel, we decided to remove region and only have a data residency setter. |
|
minor nit with the print placement, but other than that LGTM |
|
LGTM! |
tbischel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
feat!: Geolocation setter for GDPR compliance
Checklist
If you have questions, please file a support ticket.