Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped the moment, chai-as-promised, and dirty-chai version in package.json #666

Merged
merged 2 commits into from
Jun 14, 2018

Conversation

ctrimm
Copy link
Contributor

@ctrimm ctrimm commented Mar 11, 2018

Fixes

Fixes #662.

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar) - Done
  • I have read the [Contribution Guide] and my PR follows them. - Done
  • I updated my branch with the master branch. - Done
  • I have added tests that prove my fix is effective or that my feature works - No need for this
  • I have added necessary documentation about the functionality in the appropriate .md file - No need for this
  • I have added in line documentation to the code I modified - No need for this

Short description of what this PR does:

  • This PR updates the version of moment in order to avoid the potential security vulnerability that exists in versions < 2.19.3
  • While updating this dependency, I also had to update chai-as-promised and dirty-chai

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Mar 11, 2018
@SendGridDX
Copy link
Collaborator

SendGridDX commented Mar 11, 2018

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: community enhancement feature request not on Twilio's roadmap labels Mar 12, 2018
@thinkingserious
Copy link
Contributor

Thanks @ctrimm! I've added this to our backlog for a code review and merge.

With Best Regards,

Elmer

@ctrimm
Copy link
Contributor Author

ctrimm commented Mar 12, 2018

Sounds good @thinkingserious. Feel free to let me know if you all catch anything I may have missed.

@ctrimm
Copy link
Contributor Author

ctrimm commented Jun 7, 2018

Just following back up on this @thinkingserious since it has been nearly 3 months.

@thinkingserious
Copy link
Contributor

Thanks @ctrimm. This is still on our backlog and I don't have a firm date set for it's merge. I'm sorry I don't have a better answer :(

@ctrimm
Copy link
Contributor Author

ctrimm commented Jun 11, 2018

No worries @thinkingserious - just wanted to make sure it didn't get lost. 😄

@thinkingserious thinkingserious merged commit e465674 into sendgrid:master Jun 14, 2018
@thinkingserious
Copy link
Contributor

Hello @ctrimm,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repair potential security vulnerability - moment package
3 participants