Clarified how you can change the sender name #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
|
|
|
Thank you @Sundin! We have added this to our backlog for review. With Best Regards, Elmer |
clee
previously requested changes
Feb 13, 2018
There was a problem hiding this comment.
Thanks for the PR, @Sundin! Unfortunately it looks like one of the changes you made broke a link in the USE_CASES.md document. Can you please fix the broken link and resubmit your PR? (It also looks like you may need to rebase against the latest master branch.)
packages/mail/USE_CASES.md
Outdated
| @@ -15,7 +15,7 @@ This documentation provides examples for specific email use cases. Please [open | |||
| * [Specifying Time to Send At](#time-to-send) | |||
| * [Specifying Custom Headers](#custom-headers) | |||
| * [Specifying Categories](#categories) | |||
| * [Kitchen Sink - an example with all settings used](#kitchensink) | |||
| * [Kitchen Sink - an example with all settings used](#kitchen-sink---an-example-with-all-settings-used) | |||
There was a problem hiding this comment.
This change breaks the link to the Kitchen Sink example.
clee
added
status: code review complete
and removed
status: code review request
Clarified how you can change the sender name, which was not entirely obvious. Also added it to the "kitchen sink" example and fixed the link to that section in the table of contents.
|
Yep, it seems someone else fixed/changed that link during the two months since I created this PR. But my branch is now rebased with the latest changes and the link is working again! |
thinkingserious
added
difficulty: easy
|
This was very helpful! :-) |
This was referenced Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarified how you can change the sender name, which was not entirely obvious. Also added it to the "kitchen sink" example and fixed the link to that section in the table of contents.
Fixes
Checklist
Short description of what this PR does:
Some minor documentation updates.
If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.