Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TypeScript definition to support v6.X #428

Closed
thinkingserious opened this issue Aug 28, 2017 · 6 comments
Closed

Update TypeScript definition to support v6.X #428

thinkingserious opened this issue Aug 28, 2017 · 6 comments
Labels
status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

Issue Summary

v6.X is a major breaking change from v5.X, so the TypeScript definition needs an update.

@thinkingserious thinkingserious added status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap labels Aug 28, 2017
@thinkingserious
Copy link
Contributor Author

cc @spartan563

@notheotherben
Copy link
Contributor

Will take a look, can't promise that I'll get to it this week with SRECon, however I'll do what I can.

@thinkingserious
Copy link
Contributor Author

No worries @spartan563, enjoy the conference!

@bogacg
Copy link

bogacg commented Aug 30, 2017

Meanwhile SPARTAN563's PR gets reviewed, we can trick things a bit to work with Typescript:

// SINCE WE DONT HAVE TYPINGS READY FOR '@sendgrid/mail'
// REQUIRE w. any WILL  BE USED

/// <amd-dependency path="model/tree" />
declare var require: (moduleId: string) => any;
var sgMail = require('@sendgrid/mail');

@thinkingserious
Copy link
Contributor Author

Thanks @bogacg!

@thinkingserious
Copy link
Contributor Author

Solved with #430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

No branches or pull requests

3 participants