-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REST API details should not need to be included for sending email #297
Comments
Unfortunately this module behaves more like a basic helper set for constructing sendgrid payloads. And it ought to prevent malformatted json from hitting the API in the first place. At the very least, proper documentation would be preferred to learning of the module's shortcomings through errors in the API response body. Definitely needs more polish all around. |
Hello @mikemaccana, You are correct and changes are coming soon, please see: #290 Yes, the purpose of this first rewrite was to get low level support for all of the v3 Web API going, while removing the tight coupling the previous library had on the previous mail send endpoint. We invite you to join us on that journey, please take a look at this when have a moment: #290 I'm looking forward to both of your feedback as we continue down the road of fully implementing this library. Thanks for your support! I'm closing this ticket; however, please feel free to open new issues or pull requests with specific implementation details or ideas. |
Any help coming soon to remove/sidestep this helper madness? |
Hi @honkskillet, Yes :) Please follow the Mail Helper Enhancement (v3 mail/send) project if you would like to follow or contribute. @adamreisnz will propose the new helper interface there for community feedback. With Best Regards, Elmer |
Issue Summary
Helper shouldn't require user to care about methods or paths: it should help people send emails with sensible defaults, like every other API client on npm.
Steps to Reproduce
The text was updated successfully, but these errors were encountered: