Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken sticker and link in the readme file #1343

Closed
IObert opened this issue Feb 28, 2022 · 4 comments · Fixed by #1342
Closed

Broken sticker and link in the readme file #1343

IObert opened this issue Feb 28, 2022 · 4 comments · Fixed by #1342
Labels
type: docs update documentation change not affecting the code

Comments

@IObert
Copy link
Contributor

IObert commented Feb 28, 2022

Issue Summary

The first line of the readme file of each package contains a broken sticker (link AND image are broken).

Screenshot 2022-02-28 at 14 36 45

When I click the link, it sends me to this page where I see a Heroku error message: https://dx.sendgrid.com/newsletter/nodejs

Steps to Reproduce

  1. Click on broken sticker in any of the these packages:
@JenniferMah
Copy link
Contributor

Closed by #1342

@JenniferMah JenniferMah added status: help wanted requesting help from the community type: docs update documentation change not affecting the code labels Mar 3, 2022
@IObert
Copy link
Contributor Author

IObert commented Mar 4, 2022

Hi @JenniferMah,
actually the issue is still open. The PR only affected the SendGrid logo in the bottom. I wasn't sure where these stickers should point to, so I couldn't fix that one.
Can you please reopen the issue?

@JenniferMah JenniferMah reopened this Mar 4, 2022
@JenniferMah
Copy link
Contributor

Hi @IObert, Thanks for bringing this to my attention. I've gone ahead and reopened the issue! We no longer run the service that sends an email when a new package is released. The email notification badge just needs to be removed completely.

@childish-sambino
Copy link
Contributor

Fixed by d684055

@childish-sambino childish-sambino removed the status: help wanted requesting help from the community label Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants