Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "file_lines" issue in examples/mailsettings/mailsettings.java #327

Closed
thinkingserious opened this issue Oct 27, 2017 · 2 comments · Fixed by #373
Closed

Fix "file_lines" issue in examples/mailsettings/mailsettings.java #327

thinkingserious opened this issue Oct 27, 2017 · 2 comments · Fixed by #373
Labels
difficulty: easy fix is easy in difficulty status: help wanted requesting help from the community

Comments

@thinkingserious
Copy link
Contributor

thinkingserious commented Oct 27, 2017 •
edited by mbernier
Loading

File mailsettings.java has 321 lines of code (exceeds 250 allowed). Consider refactoring.

Take each of the examples and make them their own file.
Then create a README file that links to each example.

https://codeclimate.com/github/sendgrid/sendgrid-java/examples/mailsettings/mailsettings.java#issue_59f382f3ba92590001000055
@mbernier mbernier added good first issue difficulty: easy fix is easy in difficulty labels Oct 27, 2017
@adamsau
Copy link
Contributor

adamsau commented Oct 28, 2017

I will work on this issue~

@mithunsasidharan mithunsasidharan mentioned this issue Oct 29, 2017
Merged
@mithunsasidharan
Copy link
Contributor

@rivenhk : I've already submitted a PR for the issue. Thanks !

@childish-sambino childish-sambino added status: help wanted requesting help from the community and removed help wanted labels Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: help wanted requesting help from the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix file_lines issue in examples/mailsettings/mailsettings.java
5 participants
@thinkingserious @mbernier @mithunsasidharan @adamsau @childish-sambino