Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to GitHub Actions #1142

Merged
merged 18 commits into from
Nov 22, 2021
Merged

chore: migrate to GitHub Actions #1142

merged 18 commits into from
Nov 22, 2021

Conversation

eshanholtz
Copy link
Contributor

No description provided.

@eshanholtz eshanholtz marked this pull request as ready for review November 18, 2021 19:23
@eshanholtz eshanholtz marked this pull request as draft November 18, 2021 19:28
@eshanholtz eshanholtz marked this pull request as ready for review November 18, 2021 19:53
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
@eshanholtz eshanholtz marked this pull request as draft November 18, 2021 21:19
This reverts commit 9551e3c.
@eshanholtz eshanholtz marked this pull request as ready for review November 18, 2021 23:53
JenniferMah
JenniferMah previously approved these changes Nov 19, 2021
@JenniferMah
Copy link
Contributor

Travis should probably be removed from this test file.

@eshanholtz
Copy link
Contributor Author

If that test is there, then how is the test passing?? I should have seen that test failure

@JenniferMah JenniferMah dismissed their stale review November 21, 2021 17:23

Re-review after all tests are running.

Copy link
Contributor

@shwetha-manvinkurke shwetha-manvinkurke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to remove .travis.yml from the solution

@eshanholtz
Copy link
Contributor Author

@JenniferMah created DI-1844 to address running tests for sendgrid csharp libs. Out of scope for this ticket.

@eshanholtz eshanholtz merged commit 6169c51 into main Nov 22, 2021
@eshanholtz eshanholtz deleted the gh-actions branch November 22, 2021 19:08
@akunzai akunzai mentioned this pull request Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants