Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Strong name signature could not be verified #1109

Merged
merged 2 commits into from
May 18, 2021
Merged

fix: Strong name signature could not be verified #1109

merged 2 commits into from
May 18, 2021

Conversation

akunzai
Copy link
Contributor

@akunzai akunzai commented May 10, 2021 •
edited
Loading

Fixes #1045

Disable Public Signing

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label May 10, 2021
@akunzai
Copy link
Contributor Author

akunzai commented May 10, 2021

duplicated with #972

@thinkingserious
Copy link
Contributor

Build & tests passed here: https://travis-ci.com/github/sendgrid/sendgrid-csharp/builds/226153149

@thinkingserious thinkingserious merged commit 072a06f into sendgrid:main May 18, 2021
@akunzai akunzai deleted the strongnaming branch May 18, 2021 00:50
@akunzai
Copy link
Contributor Author

akunzai commented May 20, 2021

HI @thinkingserious

The version of SendGrid.Extensions.DependencyInjection was not bumped at last release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwetha-manvinkurke shwetha-manvinkurke shwetha-manvinkurke approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SendGrid.Extensions.DependencyInjection signature issue
3 participants
@akunzai @thinkingserious @shwetha-manvinkurke