Skip to content

chore: prep the repo for automated releases #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 31, 2020
Merged

chore: prep the repo for automated releases #123

merged 8 commits into from
Jan 31, 2020

Conversation

eshanholtz
Copy link
Contributor

No description provided.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 30, 2020
@codecov
Copy link

codecov bot commented Jan 30, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@0a70070). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #123   +/-   ##
=========================================
  Coverage          ?   49.29%           
  Complexity        ?       38           
=========================================
  Files             ?        5           
  Lines             ?      213           
  Branches          ?       16           
=========================================
  Hits              ?      105           
  Misses            ?      104           
  Partials          ?        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a70070...fa67d23. Read the comment docs.

thinkingserious
thinkingserious reviewed Jan 31, 2020
View reviewed changes
.travis.yml Outdated
after_script:
- "./scripts/s3upload.sh"
- "./scripts/s3upload.sh"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed, we need to upload to GitHub instead.

.travis.yml Outdated
<a href="https://github.com/sendgrid/%{repository}/commits/%{commit}">View on GitHub</a>'
format: html
notify: true
- S3_POLICY: ewogICJleHBpcmF0aW9uIjogIjIxMDAtMDEtMDFUMTI6MDA6MDAuMDAwWiIsCiAgImNvbmRpdGlvbnMiOiBbCiAgICB7ImFjbCI6ICJwdWJsaWMtcmVhZCIgfSwKICAgIHsiYnVja2V0IjogInNlbmRncmlkLW9wZW4tc291cmNlIiB9LAogICAgWyJzdGFydHMtd2l0aCIsICIka2V5IiwgInNlbmRncmlkLWphdmEvIl0sCiAgICBbImNvbnRlbnQtbGVuZ3RoLXJhbmdlIiwgMjA0OCwgMjY4NDM1NDU2XSwKICAgIFsiZXEiLCAiJENvbnRlbnQtVHlwZSIsICJhcHBsaWNhdGlvbi96aXAiXQogIF0KfQo=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can delete these, they were for uploading to S3.

thinkingserious
thinkingserious approved these changes Jan 31, 2020
View reviewed changes
@eshanholtz eshanholtz merged commit 5dd4c83 into master Jan 31, 2020
@eshanholtz eshanholtz deleted the librarian branch January 31, 2020 19:14
@thinkingserious
Copy link
Contributor

Hello @eshanholtz,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@childish-sambino childish-sambino mentioned this pull request Jul 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eshanholtz @thinkingserious