In HTTP CONNECT, use hostname parsed from TLS SNI or HTTP Host header #163
+618
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andronoob
force-pushed
the
semigodking_master
branch
from
55d2aeb
to
649d5ea
Compare
|
tl; dr: this is actually remote DNS in http-connect mode. 太长不看：这其实就是远程DNS，用在http-connect模式。 |
andronoob
force-pushed
the
semigodking_master
branch
from
649d5ea
to
0302333
Compare
|
Sorry for late response. I did not look into every line. Could you please let me know if you have do any tests? is it working without problems? Do you think it is ready? |
|
I haven't used this for quite some time. I don't remember any remaining problem last time I used it. However I cannot guarantee there's no problem either. |
|
Oh at least CI is failing: |
|
Thank you for all you have done! As we could not confirm no obvious
problem, I would like to defer merging of this PR. Will look into it and do
some tests when I have time.
andronoob ***@***.***> 于 2022年3月22日周二 00:14写道：
… Oh at least CI is failing:
Package libssl1.0-dev is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
E: Package 'libssl1.0-dev' has no installation candidate
Error: Process completed with exit code 100.
—
Reply to this email directly, view it on GitHub
<#163 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAP2XD6J6FORLVS7SPLQDJTVBCOADANCNFSM43RKQ6CQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported darkk#162 (which renews darkk#71 originally authored by @aviramc)