better compress location? #8
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ajbt200128
changed the base branch from
austin/chore_formatting_cleanup_types
to
graphite-base/8
ajbt200128
force-pushed
the
austin/better_compress_location_
branch
from
ae61e6b to
aa59594
Compare
ajbt200128
force-pushed
the
graphite-base/8
branch
from
65de76f to
9424a02
Compare
ajbt200128
changed the base branch from
graphite-base/8
to
austin/feat_switch_hash_to_faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for traces where we can compress most of the callstack, this brings down the time we spend splitting + marshalling down from 50% to ~17% of the example program. It also helps significantly reduce the # of points