Netflow plugin dev #294
Open
Netflow plugin dev #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Khodesaeed Ugh, this fell through the cracks. Thank you for contributing this. Any chance you could add a test for this? |
|
Hi, sorry for my delay, writing the unit test for this matter It's not easy. Because providing the test environment in order to write unit tests requires having access to a variety of devices and NetFlow templates. @otisg |
|
@Khodesaeed Yes, I can imagine. If you can do it, that would be greatly appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I have received
NetFlowpackets from a wide range of hardware and software devices or services that generate NetFlow packets via this npm package.