Merge pull request #10 from brech1/fix/add-members

refactor: add members

Author: vplasencia

src/baby_jubjub.rs

@@ -2,7 +2,7 @@
 //!
 //! This is an append to the the `ark-ed-on-bn254` crate to use the EIP-2494 defined Baby Jubjub curve parameters.
 //!
-//! - https://eips.ethereum.org/EIPS/eip-2494
+//! - <https://eips.ethereum.org/EIPS/eip-2494>
 //!
 //! - Base field: q = 21888242871839275222246405745257275088548364400416034343698204186575808495617
 //! - Scalar field: r = 2736030358979909402780800718157159386076813972158567259200215660948447373041

src/group.rs

@@ -108,14 +108,14 @@ impl Group {
     }
 
     /// Adds a set of members to the group
-    pub fn add_members(&mut self, members: Vec<Element>) -> Result<(), SemaphoreError> {
-        for member in &members {
-            if *member == EMPTY_ELEMENT {
+    pub fn add_members(&mut self, members: &[Element]) -> Result<(), SemaphoreError> {
+        for &member in members {
+            if member == EMPTY_ELEMENT {
                 return Err(SemaphoreError::EmptyLeaf);
             }
         }
 
-        self.tree.insert_many(&members)?;
+        self.tree.insert_many(members)?;
         Ok(())
     }
 
@@ -282,7 +282,7 @@ mod tests {
         let member1 = [1; 32];
         let member2 = [2; 32];
 
-        group.add_members(vec![member1, member2]).unwrap();
+        group.add_members(&[member1, member2]).unwrap();
 
         assert_eq!(group.size(), 2);
     }
@@ -293,7 +293,7 @@ mod tests {
         let member1 = [1; 32];
         let zero = [0u8; ELEMENT_SIZE];
 
-        let result = group.add_members(vec![member1, zero]);
+        let result = group.add_members(&[member1, zero]);
 
         assert!(result.is_err());
         assert_eq!(result, Err(SemaphoreError::EmptyLeaf));
@@ -305,7 +305,7 @@ mod tests {
         let member2 = [2; 32];
         let mut group = Group::default();
 
-        group.add_members(vec![member1, member2]).unwrap();
+        group.add_members(&[member1, member2]).unwrap();
         let index = group.index_of(member2);
 
         assert_eq!(index, Some(1));
@@ -317,7 +317,7 @@ mod tests {
         let member2 = [2; 32];
         let mut group = Group::default();
 
-        group.add_members(vec![member1, member2]).unwrap();
+        group.add_members(&[member1, member2]).unwrap();
 
         group.update_member(0, member1).unwrap();
         assert_eq!(group.size(), 2);
@@ -332,7 +332,7 @@ mod tests {
         let member2 = [2; 32];
         let mut group = Group::default();
 
-        group.add_members(vec![member1, member2]).unwrap();
+        group.add_members(&[member1, member2]).unwrap();
         group.remove_member(0).unwrap();
 
         let result = group.update_member(0, member1);
@@ -346,7 +346,7 @@ mod tests {
         let member2 = [2; 32];
         let mut group = Group::default();
 
-        group.add_members(vec![member1, member2]).unwrap();
+        group.add_members(&[member1, member2]).unwrap();
         group.remove_member(0).unwrap();
 
         let members = group.members();
@@ -360,7 +360,7 @@ mod tests {
         let member2 = [2; 32];
         let mut group = Group::default();
 
-        group.add_members(vec![member1, member2]).unwrap();
+        group.add_members(&[member1, member2]).unwrap();
         group.remove_member(0).unwrap();
 
         let result = group.remove_member(0);
@@ -375,7 +375,7 @@ mod tests {
         let member2 = [2; 32];
         let mut group = Group::default();
 
-        group.add_members(vec![member1, member2]).unwrap();
+        group.add_members(&[member1, member2]).unwrap();
 
         let proof = group.generate_proof(0).unwrap();
         assert_eq!(proof.leaf, member1);
@@ -387,7 +387,7 @@ mod tests {
         let member2 = [2; 32];
         let mut group = Group::default();
 
-        group.add_members(vec![member1, member2]).unwrap();
+        group.add_members(&[member1, member2]).unwrap();
 
         let proof_0 = group.generate_proof(0).unwrap();
         assert_eq!(Group::verify_proof(&proof_0), true);

src/lib.rs

@@ -1,7 +1,7 @@
 //! Semaphore Rust Implementation
 //!
 //! Protocol specifications:
-//! - https://github.com/zkspecs/zkspecs/tree/main/specs/3
+//! - <https://github.com/zkspecs/zkspecs/tree/main/specs/3>
 
 pub mod baby_jubjub;
 pub mod error;

tests/group.rs

@@ -123,7 +123,7 @@ mod group {
     fn add_members() {
         let mut group = Group::default();
         let elements: Vec<Element> = ADDED_MEMBERS.iter().map(|s| str_to_element(s)).collect();
-        group.add_members(elements).unwrap();
+        group.add_members(&elements).unwrap();
 
         let root = group.root().unwrap();
         assert_eq!(leaf_to_str(&root), ADD_MEMBERS_ROOT_STR);
@@ -215,7 +215,7 @@ mod group {
             .map(|s| str_to_element(s))
             .collect();
 
-        group.add_members(initial_elements).unwrap();
+        group.add_members(&initial_elements).unwrap();
         group
             .add_member(str_to_element("400000000000000000000000000000"))
             .unwrap();