Skip to content

[ATSCALE-26920]: add is_hidden property to calc groups and calculated members #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[ATSCALE-26920]: add is_hidden property to calc groups and calculated members #21

wants to merge 3 commits into from

Conversation

stanislavtrifonov88
Copy link
Contributor

ATSCALE-26920

  • added details for is_hidden flags in calculation groups and members

@github-actions GitHub Actions
Copy link

github-actions bot commented May 12, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

diannewood
diannewood reviewed May 15, 2025
View reviewed changes
diannewood
diannewood requested changes May 15, 2025
View reviewed changes
Copy link
Collaborator

@diannewood diannewood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good except the one minor comment.

diannewood
diannewood previously approved these changes May 20, 2025
View reviewed changes
Copy link
Collaborator

@diannewood diannewood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

svetoslavpetkov
svetoslavpetkov approved these changes May 21, 2025
View reviewed changes
Copy link
Collaborator

@svetoslavpetkov svetoslavpetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanislavtrifonov88
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

diannewood
diannewood approved these changes May 21, 2025
View reviewed changes
Copy link
Collaborator

@diannewood diannewood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanislavtrifonov88 stanislavtrifonov88 changed the title feat: add is_hidden property to calc groups and calculated members [ATSCALE-26920]: add is_hidden property to calc groups and calculated members May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diannewood diannewood diannewood approved these changes

@svetoslavpetkov svetoslavpetkov svetoslavpetkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stanislavtrifonov88 @diannewood @svetoslavpetkov