Skip to content

Updates to gist:requires. Fixes #183. #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

rjyounes
Copy link
Collaborator

  • Remove domain and range constraints
  • Change definition, add an example

@rjyounes rjyounes requested a review from dylan-sa January 14, 2022 20:26
@rjyounes
Copy link
Collaborator Author

@dylan-sa Let me know if you can think of a better definition. I'm not thrilled with this one.

Copy link
Contributor

@dylan-sa dylan-sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjyounes Looks good to me. I think the definition is tough to improve, but I'll offer a couple alternatives in case they inspire some tweaks:

  • 'The occurrence or existence of the object is a necessary condition for the occurrence or existence of the subject'

  • 'The object's obtaining is a necessary condition for the subject's obtaining'

These options are a little more wordy, but they may help to paint a picture of what's really going on when we say 'x requires y'. For example, 'the contract requires two signatures' might mean 'the existence of two signatures is a necessary condition for the existence of the contract'.

@rjyounes rjyounes marked this pull request as draft January 15, 2022 17:40
@rjyounes rjyounes changed the title Updates to gist:requires Updates to gist:requires. Fixes #183. Jan 15, 2022
@rjyounes
Copy link
Collaborator Author

DECISION: One predicate, define as

"To need something or to make something necessary."

scopeNote to indicate the different senses.

@rjyounes rjyounes requested a review from uscholdm January 27, 2022 22:57
@rjyounes rjyounes added the impact: patch No new functionality or changes in human-readable semantics (e.g,. fixing a typo in an annotation) label Jan 27, 2022
@rjyounes rjyounes marked this pull request as ready for review January 27, 2022 23:01
@rjyounes rjyounes force-pushed the feature/issue_183_requires branch from 022900c to 51f49ce Compare January 28, 2022 18:25
@rjyounes rjyounes closed this Feb 9, 2022
@rjyounes rjyounes deleted the feature/issue_183_requires branch February 9, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: patch No new functionality or changes in human-readable semantics (e.g,. fixing a typo in an annotation)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants