Skip to content

Changes to Agreement, Commitment, and Obligation #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

Changes to Agreement, Commitment, and Obligation #1221

wants to merge 20 commits into from

Conversation

pppelll
Copy link

@pppelll pppelll commented May 22, 2025

closes #1188

gist:ContingentObligation has changed to gist:ContingentCommitment following the deletion of gist:Obligation. The definition of this class probably warrants extra attention with the new ways of modelling these concepts, and might require discussion during the next gist dev meeting.

@pppelll
Updated gistCore file to reflect changes pertaining to issue 1188 agr…
360c4a1 
…eed upon during 22 May 2025 gist development forum.
@pppelll pppelll self-assigned this May 22, 2025
@pppelll pppelll added the impact: major Non-backward compatible (changes inferences; e.g., adding a restriction, domain, range) label May 22, 2025
@pppelll pppelll linked an issue May 22, 2025 that may be closed by this pull request
Changes to Agreement, Commitment, and Obligation #1188
Open
3 tasks
@dylan-sa dylan-sa moved this to In Review in gist Version 14.0.0 May 22, 2025
dylan-sa
dylan-sa requested changes May 22, 2025
View reviewed changes
Copy link
Contributor

@dylan-sa dylan-sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some tweaks to make.

rjyounes
rjyounes reviewed May 27, 2025
View reviewed changes
Copy link
Collaborator

@rjyounes rjyounes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested revisions to a number of your annotations. Regard these as hints about direction rather than hard-and-fast replacements. You may also want to add an example for each term; the Cambridge dictionary provides a lot of ideas for examples.

We prefer language which is clear and unambiguous but not overly technical; it should be easily understood by most ordinary readers.

rjyounes
rjyounes reviewed May 27, 2025
View reviewed changes
Copy link
Collaborator

@rjyounes rjyounes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to request changes but submitted the review before doing so.

@rjyounes rjyounes self-requested a review May 27, 2025 18:27
rjyounes
rjyounes requested changes May 27, 2025
View reviewed changes
Copy link
Collaborator

@rjyounes rjyounes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still didn't work.

pppelll and others added 7 commits May 27, 2025 15:23
@pppelll @rjyounes
Update docs/release_notes/issue1188-changes-to-agreement-commitment-a…
81ff92d 
…nd-obligation.md

Co-authored-by: Rebecca Younes <rebecca.younes@semanticarts.com>
@pppelll @rjyounes
Update docs/release_notes/issue1188-changes-to-agreement-commitment-a…
9a2a80d 
…nd-obligation.md

Co-authored-by: Rebecca Younes <rebecca.younes@semanticarts.com>
@pppelll @rjyounes
Update docs/release_notes/issue1188-changes-to-agreement-commitment-a…
297d9d1 
…nd-obligation.md

Co-authored-by: Rebecca Younes <rebecca.younes@semanticarts.com>
@pppelll
updates to release notes
931c8fd
@pppelll
Made changes as suggested, and added examples.
bc48b6c
@pppelll
syntax fixes
eea2bfe
@pppelll
fixed syntax
c1ab35d
uscholdm
uscholdm reviewed May 28, 2025
View reviewed changes
uscholdm
uscholdm reviewed May 28, 2025
View reviewed changes
@pppelll pppelll requested review from rjyounes and dylan-sa May 29, 2025 19:32
@pppelll
Copy link
Author

pppelll commented May 29, 2025

I have pushed a new version which takes into account suggestions from @dylan-sa , @rjyounes , and @uscholdm .

uscholdm
uscholdm reviewed May 30, 2025
View reviewed changes
Copy link
Contributor

@uscholdm uscholdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great - a few more suggested tweaks before I re-review the whole thing again from scratch.

uscholdm
uscholdm requested changes May 30, 2025
View reviewed changes
Copy link
Contributor

@uscholdm uscholdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more wording tweaks, mainly for brevity - regard them as optional, as you prefer.

pppelll and others added 4 commits June 3, 2025 08:50
@pppelll @uscholdm
Update ontologies/gistCore.ttl
9f8898d 
Used Michael's suggested wording.

Co-authored-by: Michael Uschold <uscholdm@users.noreply.github.com>
@pppelll @uscholdm
Update ontologies/gistCore.ttl
5352054 
Reduced the scope of the example annotation to be just price (not frequency) and just access (not maintenance).

Co-authored-by: Michael Uschold <uscholdm@users.noreply.github.com>
@pppelll @uscholdm
Update ontologies/gistCore.ttl
885fe5a 
Co-authored-by: Michael Uschold <uscholdm@users.noreply.github.com>
@pppelll @uscholdm
Update ontologies/gistCore.ttl
848fadd 
Clarifying language according to Michael's suggestions

Co-authored-by: Michael Uschold <uscholdm@users.noreply.github.com>
uscholdm
uscholdm reviewed Jun 4, 2025
View reviewed changes
Copy link
Contributor

@uscholdm uscholdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nearly ready, I see one or more unresolved comments/suggestions

pppelll and others added 3 commits June 4, 2025 11:08
@pppelll @uscholdm
Update ontologies/gistCore.ttl
9dc1299 
Taking Michael's suggestions to clarify the language

Co-authored-by: Michael Uschold <uscholdm@users.noreply.github.com>
@pppelll @uscholdm
Update docs/release_notes/issue1188-changes-to-agreement-commitment-a…
9715bf6 
…nd-obligation.md


Small change to release notes

Co-authored-by: Michael Uschold <uscholdm@users.noreply.github.com>
@pppelll @uscholdm
Update ontologies/gistCore.ttl
8ce1fcc 
Co-authored-by: Michael Uschold <uscholdm@users.noreply.github.com>
uscholdm
uscholdm approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@uscholdm uscholdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good now. Lets see what Rebecca thinks.

@rjyounes rjyounes changed the title Address changes in issue 1188 Changes to Agreement, Commitment, and Obligation Jun 4, 2025
@rjyounes
Copy link
Collaborator

rjyounes commented Jun 4, 2025

@pppelll Just for future reference, please give PRs titles that explain something about what they are doing rather than referencing an issue number. The description is useful when scanning a list of PRs. Thanks.

@uscholdm uscholdm mentioned this pull request Jun 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uscholdm uscholdm uscholdm approved these changes

@brett-heffelfinger brett-heffelfinger Awaiting requested review from brett-heffelfinger

@rjyounes rjyounes Awaiting requested review from rjyounes

@dylan-sa dylan-sa Awaiting requested review from dylan-sa

Requested changes must be addressed to merge this pull request.

Assignees

@pppelll pppelll

Labels
impact: major Non-backward compatible (changes inferences; e.g., adding a restriction, domain, range)
Projects
gist Version 14.0.0
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changes to Agreement, Commitment, and Obligation
4 participants
@pppelll @rjyounes @uscholdm @dylan-sa