Make Kattbot slightly dumb again

Only responds when spoken to.

Author: selfdocumentingcode

src/Kattbot/NotificationHandlers/KattGptMessageHandler.cs

@@ -29,9 +29,9 @@ public class KattGptMessageHandler : BaseNotificationHandler,
 
     private const int MaxTotalTokens = 24_576;
     private const int MaxTokensToGenerate = 960; // Roughly the limit of 2 Discord messages
+
     private const string MessageSplitToken = "[cont.] ";
-    private const string RecipientMarkerToYou = "[to you]";
-    private const string RecipientMarkerToOthers = "[to others]";
+
     private const string MessageToolUseTemplate = "`Kattbot used: {0}`";
 
     private const string GptImageModel = "gpt-image-1";
@@ -85,26 +85,16 @@ public async Task Handle(MessageCreatedNotification notification, CancellationTo
                 systemPromptsMessages,
                 chatCompletionFunction);
 
-            bool shouldReplyToMessage = ShouldReplyToMessage(message);
-
-            string recipientMarker = shouldReplyToMessage
-                ? RecipientMarkerToYou
-                : RecipientMarkerToOthers;
-
             // Add the new message from notification
             string newMessageUser = author.GetDisplayName();
             string newMessageContent = message.SubstituteMentions();
 
             ChatCompletionMessage newUserMessage =
-                ChatCompletionMessage.AsUser($"{newMessageUser}{recipientMarker}: {newMessageContent}");
+                ChatCompletionMessage.AsUser($"{newMessageUser}: {newMessageContent}");
 
             newContextMessages.Add(newUserMessage);
 
-            if (!shouldReplyToMessage)
-            {
-                channelContext.AddMessages(newContextMessages);
-                return;
-            }
+            channelContext.AddMessages(newContextMessages);
 
             await channel.TriggerTypingAsync();
 
@@ -379,31 +369,7 @@ private bool ShouldHandleMessage(DiscordMessage message)
 
         if (channelOptions == null) return false;
 
-        // if the channel is not always on, handle the message
-        if (!channelOptions.AlwaysOn) return true;
-
-        // otherwise check if the message does not start with the MetaMessagePrefix
-        string[] metaMessagePrefixes = _kattGptOptions.AlwaysOnIgnoreMessagePrefixes;
-        bool messageStartsWithMetaMessagePrefix = metaMessagePrefixes.Any(messageContent.StartsWith);
-
-        // if it does, return false
-        return !messageStartsWithMetaMessagePrefix;
-    }
-
-    /// <summary>
-    ///     Checks if KattGpt should reply to the message.
-    /// </summary>
-    /// <param name="message">The message.</param>
-    /// <returns>True if KattGpt should reply.</returns>
-    private bool ShouldReplyToMessage(DiscordMessage message)
-    {
-        DiscordChannel channel = message.Channel!;
-
-        ChannelOptions? channelOptions = _kattGptService.GetChannelOptions(channel);
-
-        if (channelOptions == null) return false;
-
-        // if the channel is not always on
+        // if the channel is not always on i.e. requires @mention or Reply
         if (!channelOptions.AlwaysOn)
         {
             // check if the current message is a reply to kattbot
@@ -419,7 +385,7 @@ private bool ShouldReplyToMessage(DiscordMessage message)
 
         // otherwise check if the message does not start with the MetaMessagePrefix
         string[] metaMessagePrefixes = _kattGptOptions.AlwaysOnIgnoreMessagePrefixes;
-        bool messageStartsWithMetaMessagePrefix = metaMessagePrefixes.Any(message.Content.TrimStart().StartsWith);
+        bool messageStartsWithMetaMessagePrefix = metaMessagePrefixes.Any(messageContent.StartsWith);
 
         // if it does, return false
         return !messageStartsWithMetaMessagePrefix;

src/Kattbot/appsettings.json

@@ -34,10 +34,9 @@
       "",
       "**Communication in Discord Channels:**",
       "- Interaction: Only engage in conversations when directly addressed by users.",
-      "- Addressing: Messages from users will be prefixed with their name and the recipient marker ([to others] or [to you]).",
-      "    - Example: \"Alice[to others]: Hello, everyone! What’s up?\".",
-      "    - Example: \"Bob[to you]: Hello, how are you?\".",
-      "- Response: Respond without prefixing your message with your name or a recipient marker. Use the name of the person addressing you to make the interaction more personal.",
+      "- Addressing: Messages from users will be prefixed with their name.",
+      "    - Example: \"Bob: Hello, how are you?\".",
+      "- Response: Respond using the name of the person addressing you to make the interaction more personal. Subsequent messages may omit the person's name.",
       "    - Example: \"Hey, Bob! I’m doing quite well. How about you?\"",
       "",
       "**General Communication Guidelines:**",
@@ -50,7 +49,7 @@
       "- Image Requests: Generate images only when requested by users.",
       "- When sharing an image that you generate, do not include textual indicators like \"[Attaches image]\" or \"[Generated image]\" within the message. The generated image is automatically added to your reply.",
       "    - Example: ",
-      "        - User: \"John[to you]: Can you draw a cat sitting on a moon?\"",
+      "        - User: \"John: Can you draw a cat sitting on a moon?\"",
       "        - Kattbot: \"Sure thing, John! Here’s your cat lounging on a moon!\" [This message contains the generated image]"
     ],
     "Templates": [