Skip to content

Commit aaa7e79

Browse files
pujaganipujagani
authored
[bidi][java] Enable chrome tests (#13770)
1 parent 68ad984 commit aaa7e79

17 files changed

+26
-61
lines changed

‎java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public boolean isSupportingCdp() {
6060

6161
@Override
6262
public boolean isSupportingBiDi() {
63-
return false;
63+
return true;
6464
}
6565

6666
@Override

‎java/test/org/openqa/selenium/bidi/browser/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ java_selenium_test_suite(
66
size = "large",
77
srcs = glob(["*Test.java"]),
88
browsers = [
9+
"chrome",
910
"firefox",
1011
],
1112
tags = [

‎java/test/org/openqa/selenium/bidi/browsingcontext/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ java_selenium_test_suite(
66
size = "large",
77
srcs = glob(["*Test.java"]),
88
browsers = [
9+
"chrome",
910
"firefox",
1011
],
1112
tags = [

‎java/test/org/openqa/selenium/bidi/browsingcontext/BrowsingContextInspectorTest.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ public void setUp() {
5252
@Test
5353
@NotYetImplemented(SAFARI)
5454
@NotYetImplemented(IE)
55-
@NotYetImplemented(CHROME)
5655
@NotYetImplemented(EDGE)
5756
void canListenToWindowBrowsingContextCreatedEvent()
5857
throws ExecutionException, InterruptedException, TimeoutException {
@@ -76,7 +75,6 @@ void canListenToWindowBrowsingContextCreatedEvent()
7675
@Test
7776
@NotYetImplemented(SAFARI)
7877
@NotYetImplemented(IE)
79-
@NotYetImplemented(CHROME)
8078
@NotYetImplemented(EDGE)
8179
void canListenToBrowsingContextDestroyedEvent()
8280
throws ExecutionException, InterruptedException, TimeoutException {
@@ -101,7 +99,6 @@ void canListenToBrowsingContextDestroyedEvent()
10199
@Test
102100
@NotYetImplemented(SAFARI)
103101
@NotYetImplemented(IE)
104-
@NotYetImplemented(CHROME)
105102
@NotYetImplemented(EDGE)
106103
void canListenToTabBrowsingContextCreatedEvent()
107104
throws ExecutionException, InterruptedException, TimeoutException {
@@ -124,7 +121,6 @@ void canListenToTabBrowsingContextCreatedEvent()
124121
@Test
125122
@NotYetImplemented(SAFARI)
126123
@NotYetImplemented(IE)
127-
@NotYetImplemented(CHROME)
128124
@NotYetImplemented(EDGE)
129125
void canListenToDomContentLoadedEvent()
130126
throws ExecutionException, InterruptedException, TimeoutException {
@@ -144,7 +140,6 @@ void canListenToDomContentLoadedEvent()
144140
@Test
145141
@NotYetImplemented(SAFARI)
146142
@NotYetImplemented(IE)
147-
@NotYetImplemented(CHROME)
148143
@NotYetImplemented(EDGE)
149144
void canListenToBrowsingContextLoadedEvent()
150145
throws ExecutionException, InterruptedException, TimeoutException {
@@ -184,7 +179,6 @@ void canListenToNavigationStartedEvent()
184179
@Test
185180
@NotYetImplemented(SAFARI)
186181
@NotYetImplemented(IE)
187-
@NotYetImplemented(CHROME)
188182
@NotYetImplemented(EDGE)
189183
void canListenToFragmentNavigatedEvent()
190184
throws ExecutionException, InterruptedException, TimeoutException {
@@ -208,7 +202,6 @@ void canListenToFragmentNavigatedEvent()
208202
@Test
209203
@NotYetImplemented(SAFARI)
210204
@NotYetImplemented(IE)
211-
@NotYetImplemented(CHROME)
212205
@NotYetImplemented(EDGE)
213206
void canListenToUserPromptOpenedEvent()
214207
throws ExecutionException, InterruptedException, TimeoutException {
@@ -231,7 +224,6 @@ void canListenToUserPromptOpenedEvent()
231224
@Test
232225
@NotYetImplemented(SAFARI)
233226
@NotYetImplemented(IE)
234-
@NotYetImplemented(CHROME)
235227
@NotYetImplemented(EDGE)
236228
void canListenToUserPromptClosedEvent()
237229
throws ExecutionException, InterruptedException, TimeoutException {

‎java/test/org/openqa/selenium/bidi/browsingcontext/BrowsingContextTest.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import static org.openqa.selenium.support.ui.ExpectedConditions.titleIs;
2424
import static org.openqa.selenium.support.ui.ExpectedConditions.visibilityOfElementLocated;
2525
import static org.openqa.selenium.testing.Safely.safelyCall;
26-
import static org.openqa.selenium.testing.drivers.Browser.CHROME;
2726
import static org.openqa.selenium.testing.drivers.Browser.EDGE;
2827
import static org.openqa.selenium.testing.drivers.Browser.FIREFOX;
2928
import static org.openqa.selenium.testing.drivers.Browser.IE;
@@ -77,7 +76,6 @@ void canCreateAWindow() {
7776
@Test
7877
@NotYetImplemented(SAFARI)
7978
@NotYetImplemented(IE)
80-
@NotYetImplemented(CHROME)
8179
@NotYetImplemented(EDGE)
8280
void canCreateAWindowWithAReferenceContext() {
8381
BrowsingContext browsingContext =
@@ -96,7 +94,6 @@ void canCreateATab() {
9694
@Test
9795
@NotYetImplemented(SAFARI)
9896
@NotYetImplemented(IE)
99-
@NotYetImplemented(CHROME)
10097
@NotYetImplemented(EDGE)
10198
void canCreateATabWithAReferenceContext() {
10299
BrowsingContext browsingContext =
@@ -133,7 +130,6 @@ void canNavigateToAUrlWithReadinessState() {
133130
@Test
134131
@NotYetImplemented(SAFARI)
135132
@NotYetImplemented(IE)
136-
@NotYetImplemented(CHROME)
137133
@NotYetImplemented(EDGE)
138134
void canGetTreeWithAChild() {
139135
String referenceContextId = driver.getWindowHandle();
@@ -155,7 +151,6 @@ void canGetTreeWithAChild() {
155151
@Test
156152
@NotYetImplemented(SAFARI)
157153
@NotYetImplemented(IE)
158-
@NotYetImplemented(CHROME)
159154
@NotYetImplemented(EDGE)
160155
void canGetTreeWithDepth() {
161156
String referenceContextId = driver.getWindowHandle();
@@ -239,7 +234,6 @@ void canReloadABrowsingContext() {
239234

240235
NavigationResult reloadInfo = browsingContext.reload();
241236

242-
assertThat(reloadInfo.getNavigationId()).isNotNull();
243237
assertThat(reloadInfo.getUrl()).contains("/bidi/logEntryAdded.html");
244238
}
245239

@@ -410,7 +404,6 @@ void canCaptureScreenshotWithAllParameters() {
410404
@Test
411405
@NotYetImplemented(SAFARI)
412406
@NotYetImplemented(IE)
413-
@NotYetImplemented(CHROME)
414407
void canCaptureScreenshotOfViewport() {
415408
BrowsingContext browsingContext = new BrowsingContext(driver, driver.getWindowHandle());
416409

@@ -429,7 +422,6 @@ void canCaptureScreenshotOfViewport() {
429422
@Test
430423
@NotYetImplemented(SAFARI)
431424
@NotYetImplemented(IE)
432-
@NotYetImplemented(CHROME)
433425
void canCaptureElementScreenshot() {
434426
BrowsingContext browsingContext = new BrowsingContext(driver, driver.getWindowHandle());
435427

@@ -464,7 +456,6 @@ void canSetViewport() {
464456
@Test
465457
@NotYetImplemented(SAFARI)
466458
@NotYetImplemented(IE)
467-
@NotYetImplemented(CHROME)
468459
@NotYetImplemented(FIREFOX)
469460
void canSetViewportWithDevicePixelRatio() {
470461
BrowsingContext browsingContext = new BrowsingContext(driver, driver.getWindowHandle());
@@ -508,7 +499,6 @@ void canPrintPage() {
508499
@Test
509500
@NotYetImplemented(SAFARI)
510501
@NotYetImplemented(IE)
511-
@NotYetImplemented(CHROME)
512502
void canNavigateBackInTheBrowserHistory() {
513503
BrowsingContext browsingContext = new BrowsingContext(driver, driver.getWindowHandle());
514504
browsingContext.navigate(pages.formPage, ReadinessState.COMPLETE);
@@ -523,7 +513,6 @@ void canNavigateBackInTheBrowserHistory() {
523513
@Test
524514
@NotYetImplemented(SAFARI)
525515
@NotYetImplemented(IE)
526-
@NotYetImplemented(CHROME)
527516
void canNavigateForwardInTheBrowserHistory() {
528517
BrowsingContext browsingContext = new BrowsingContext(driver, driver.getWindowHandle());
529518
browsingContext.navigate(pages.formPage, ReadinessState.COMPLETE);

‎java/test/org/openqa/selenium/bidi/input/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ java_selenium_test_suite(
66
size = "large",
77
srcs = glob(["*Test.java"]),
88
browsers = [
9+
"chrome",
910
"firefox",
1011
],
1112
data = [

‎java/test/org/openqa/selenium/bidi/input/CombinedInputActionsTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,7 @@ private void navigateToClicksPageAndClickLink() {
260260
@NotYetImplemented(SAFARI)
261261
@NotYetImplemented(IE)
262262
@NotYetImplemented(EDGE)
263+
@NotYetImplemented(CHROME)
263264
void canMoveMouseToAnElementInAnIframeAndClick() {
264265
driver.get(appServer.whereIs("click_tests/click_in_iframe.html"));
265266

‎java/test/org/openqa/selenium/bidi/input/DefaultMouseTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,7 @@ void testContextClick() {
224224
@NeedsFreshDriver
225225
@Test
226226
@Ignore(value = FIREFOX, gitHubActions = true)
227+
@Ignore(value = CHROME, gitHubActions = true)
227228
@NotYetImplemented(SAFARI)
228229
@NotYetImplemented(IE)
229230
@NotYetImplemented(EDGE)
@@ -263,6 +264,7 @@ void testMoveAndClick() {
263264
@NotYetImplemented(SAFARI)
264265
@NotYetImplemented(IE)
265266
@NotYetImplemented(EDGE)
267+
@NotYetImplemented(CHROME)
266268
void testShouldClickElementInIFrame() {
267269
driver.get(pages.clicksPage);
268270
driver.switchTo().frame("source");

‎java/test/org/openqa/selenium/bidi/log/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ java_selenium_test_suite(
66
size = "large",
77
srcs = glob(["*Test.java"]),
88
browsers = [
9+
"chrome",
910
"firefox",
1011
],
1112
tags = [

‎java/test/org/openqa/selenium/bidi/network/NetworkCommandsTest.java

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,7 @@
2020
import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
2121
import static org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy;
2222
import static org.openqa.selenium.testing.Safely.safelyCall;
23-
import static org.openqa.selenium.testing.drivers.Browser.EDGE;
24-
import static org.openqa.selenium.testing.drivers.Browser.FIREFOX;
25-
import static org.openqa.selenium.testing.drivers.Browser.IE;
26-
import static org.openqa.selenium.testing.drivers.Browser.SAFARI;
23+
import static org.openqa.selenium.testing.drivers.Browser.*;
2724

2825
import java.time.Duration;
2926
import java.time.temporal.ChronoUnit;
@@ -59,6 +56,7 @@ public void setUp() {
5956
@NotYetImplemented(SAFARI)
6057
@NotYetImplemented(IE)
6158
@NotYetImplemented(EDGE)
59+
@NotYetImplemented(CHROME)
6260
void canAddIntercept() {
6361
try (Network network = new Network(driver)) {
6462
String intercept =
@@ -71,6 +69,7 @@ void canAddIntercept() {
7169
@NotYetImplemented(SAFARI)
7270
@NotYetImplemented(IE)
7371
@NotYetImplemented(EDGE)
72+
@NotYetImplemented(CHROME)
7473
void canContinueRequest() throws InterruptedException {
7574
try (Network network = new Network(driver)) {
7675
String intercept =
@@ -105,6 +104,7 @@ void canContinueRequest() throws InterruptedException {
105104
@NotYetImplemented(SAFARI)
106105
@NotYetImplemented(IE)
107106
@NotYetImplemented(EDGE)
107+
@NotYetImplemented(CHROME)
108108
void canContinueResponse() throws InterruptedException {
109109
try (Network network = new Network(driver)) {
110110
String intercept =
@@ -134,6 +134,7 @@ void canContinueResponse() throws InterruptedException {
134134
@NotYetImplemented(SAFARI)
135135
@NotYetImplemented(IE)
136136
@NotYetImplemented(EDGE)
137+
@NotYetImplemented(CHROME)
137138
void canProvideResponse() throws InterruptedException {
138139
try (Network network = new Network(driver)) {
139140
String intercept =
@@ -163,6 +164,7 @@ void canProvideResponse() throws InterruptedException {
163164
@NotYetImplemented(IE)
164165
@NotYetImplemented(EDGE)
165166
@NotYetImplemented(FIREFOX)
167+
@NotYetImplemented(CHROME)
166168
// TODO: Browsers are yet to implement all parameters. Once implemented, add exhaustive tests.
167169
void canProvideResponseWithAllParameters() throws InterruptedException {
168170
try (Network network = new Network(driver)) {
@@ -198,6 +200,7 @@ void canProvideResponseWithAllParameters() throws InterruptedException {
198200
@NotYetImplemented(SAFARI)
199201
@NotYetImplemented(IE)
200202
@NotYetImplemented(EDGE)
203+
@NotYetImplemented(CHROME)
201204
void canRemoveIntercept() {
202205
try (Network network = new Network(driver)) {
203206
String intercept =
@@ -212,6 +215,7 @@ void canRemoveIntercept() {
212215
@NotYetImplemented(SAFARI)
213216
@NotYetImplemented(IE)
214217
@NotYetImplemented(EDGE)
218+
@NotYetImplemented(CHROME)
215219
void canContinueWithAuthCredentials() {
216220
try (Network network = new Network(driver)) {
217221
network.addIntercept(new AddInterceptParameters(InterceptPhase.AUTH_REQUIRED));
@@ -231,6 +235,7 @@ void canContinueWithAuthCredentials() {
231235
@NotYetImplemented(SAFARI)
232236
@NotYetImplemented(IE)
233237
@NotYetImplemented(EDGE)
238+
@NotYetImplemented(CHROME)
234239
void canContinueWithoutAuthCredentials() {
235240
try (Network network = new Network(driver)) {
236241
network.addIntercept(new AddInterceptParameters(InterceptPhase.AUTH_REQUIRED));
@@ -250,6 +255,7 @@ void canContinueWithoutAuthCredentials() {
250255
@NotYetImplemented(SAFARI)
251256
@NotYetImplemented(IE)
252257
@NotYetImplemented(EDGE)
258+
@NotYetImplemented(CHROME)
253259
void canCancelAuth() {
254260
try (Network network = new Network(driver)) {
255261
network.addIntercept(new AddInterceptParameters(InterceptPhase.AUTH_REQUIRED));
@@ -268,6 +274,7 @@ void canCancelAuth() {
268274
@NotYetImplemented(SAFARI)
269275
@NotYetImplemented(IE)
270276
@NotYetImplemented(EDGE)
277+
@NotYetImplemented(CHROME)
271278
void canFailRequest() {
272279
try (Network network = new Network(driver)) {
273280
network.addIntercept(new AddInterceptParameters(InterceptPhase.BEFORE_REQUEST_SENT));

‎java/test/org/openqa/selenium/bidi/network/NetworkEventsTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,7 @@
1919

2020
import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
2121
import static org.openqa.selenium.testing.Safely.safelyCall;
22-
import static org.openqa.selenium.testing.drivers.Browser.EDGE;
23-
import static org.openqa.selenium.testing.drivers.Browser.IE;
24-
import static org.openqa.selenium.testing.drivers.Browser.SAFARI;
22+
import static org.openqa.selenium.testing.drivers.Browser.*;
2523

2624
import java.util.concurrent.CompletableFuture;
2725
import java.util.concurrent.ExecutionException;
@@ -148,6 +146,7 @@ void canListenToResponseCompletedEventWithCookie()
148146
@NotYetImplemented(SAFARI)
149147
@NotYetImplemented(IE)
150148
@NotYetImplemented(EDGE)
149+
@NotYetImplemented(CHROME)
151150
void canListenToOnAuthRequiredEvent()
152151
throws ExecutionException, InterruptedException, TimeoutException {
153152
try (Network network = new Network(driver)) {
@@ -172,6 +171,7 @@ void canListenToOnAuthRequiredEvent()
172171
@NotYetImplemented(SAFARI)
173172
@NotYetImplemented(IE)
174173
@NotYetImplemented(EDGE)
174+
@NotYetImplemented(CHROME)
175175
void canListenToFetchError() throws ExecutionException, InterruptedException, TimeoutException {
176176
try (Network network = new Network(driver)) {
177177
CompletableFuture<FetchError> future = new CompletableFuture<>();

‎java/test/org/openqa/selenium/bidi/script/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ java_selenium_test_suite(
66
size = "large",
77
srcs = glob(["*Test.java"]),
88
browsers = [
9+
"chrome",
910
"firefox",
1011
],
1112
tags = [

0 commit comments

Comments
 (0)