Skip to content

Commit 8688ad2

Browse files
committed
[rb] Fix Chromium tests on Windows
Apparently no-sandbox would keep zombie Chromium processes and would starve the resources. See #5600.
1 parent ef96a7b commit 8688ad2

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

.github/workflows/ci-ruby.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,6 @@ jobs:
8787
os: ubuntu
8888
- browser: safari
8989
os: windows
90-
# TODO: Investigate why they are timing out
91-
- browser: chrome
92-
os: windows
93-
- browser: edge
94-
os: windows
9590
with:
9691
name: Local Tests (${{ matrix.browser }}, ${{ matrix.os }})
9792
browser: ${{ matrix.browser }}

rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,15 +243,13 @@ def safari_preview_driver(**opts)
243243
def chrome_options(args: [], **opts)
244244
opts[:binary] ||= ENV['CHROME_BINARY'] if ENV.key?('CHROME_BINARY')
245245
args << '--headless=chrome' if ENV['HEADLESS']
246-
args << '--no-sandbox'
247246
args << '--disable-gpu'
248247
WebDriver::Options.chrome(browser_version: 'stable', args: args, **opts)
249248
end
250249

251250
def edge_options(args: [], **opts)
252251
opts[:binary] ||= ENV['EDGE_BINARY'] if ENV.key?('EDGE_BINARY')
253252
args << '--headless=chrome' if ENV['HEADLESS']
254-
args << '--no-sandbox'
255253
args << '--disable-gpu'
256254
WebDriver::Options.edge(browser_version: 'stable', args: args, **opts)
257255
end

0 commit comments

Comments
 (0)