Skip to content

Commit a3cc95c

Browse files
committed
Fix locale settings
1 parent 1db2f1c commit a3cc95c

File tree

4 files changed

+8
-2
lines changed

4 files changed

+8
-2
lines changed

seleniumbase/core/browser_launcher.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2169,6 +2169,9 @@ def _set_chrome_options(
21692169
prefs["profile.default_content_setting_values.automatic_downloads"] = 1
21702170
if locale_code:
21712171
prefs["intl.accept_languages"] = locale_code
2172+
sb_config._cdp_locale = locale_code
2173+
else:
2174+
sb_config._cdp_locale = None
21722175
if block_images:
21732176
prefs["profile.managed_default_content_settings.images"] = 2
21742177
if disable_cookies:

seleniumbase/undetected/cdp_driver/browser.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -323,6 +323,8 @@ async def get(
323323
_cdp_locale = kwargs["locale"]
324324
elif "lang" in kwargs:
325325
_cdp_locale = kwargs["lang"]
326+
elif "locale_code" in kwargs:
327+
_cdp_locale = kwargs["locale_code"]
326328
if "platform" in kwargs:
327329
_cdp_platform = kwargs["platform"]
328330
elif "plat" in kwargs:
@@ -336,6 +338,8 @@ async def get(
336338
if _cdp_timezone:
337339
await connection.send(cdp.page.navigate("about:blank"))
338340
await connection.set_timezone(_cdp_timezone)
341+
if _cdp_locale:
342+
await connection.set_locale(_cdp_locale)
339343
if _cdp_user_agent or _cdp_locale or _cdp_platform:
340344
await connection.send(cdp.page.navigate("about:blank"))
341345
await connection.set_user_agent(

seleniumbase/undetected/cdp_driver/cdp_util.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -370,8 +370,6 @@ async def start(
370370
sb_config._cdp_locale = kwargs["locale"]
371371
elif "locale_code" in kwargs:
372372
sb_config._cdp_locale = kwargs["locale_code"]
373-
else:
374-
sb_config._cdp_locale = None
375373
if tzone:
376374
sb_config._cdp_timezone = tzone
377375
elif "timezone" in kwargs:

seleniumbase/undetected/cdp_driver/connection.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -347,6 +347,7 @@ async def wait(self, t: Union[int, float] = None):
347347
async def set_locale(self, locale: Optional[str] = None):
348348
"""Sets the Language Locale code via set_user_agent_override."""
349349
await self.set_user_agent(user_agent="", accept_language=locale)
350+
await self.send(cdp.emulation.set_locale_override(locale))
350351

351352
async def set_timezone(self, timezone: Optional[str] = None):
352353
"""Sets the Timezone via set_timezone_override."""

0 commit comments

Comments
 (0)