Fixed incorrect highlighting of options that were activated, removed and then re-added in "multiple" mode #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-maltsev
pushed a commit
to michael-maltsev/selectize.js
that referenced
this pull request
Aug 28, 2018
…and then re-added in "multiple" mode selectize#1420
sustmi
force-pushed
the
fix-removing-active
branch
from
f25fba1
to
7ac5e6f
Compare
…and then re-added in "multiple" mode Fixes issues selectize#1212 and selectize#1216.
sustmi
force-pushed
the
fix-removing-active
branch
from
7ac5e6f
to
18809a9
Compare
|
I rebased the code on the current |
|
Stale pull request message |
|
@risadams May want to consider merging this? |
risadams
added
pending review
risadams
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues:
The incorrect behavior can be seen in the following screen-capture:
Also, here is a codepen: https://codepen.io/anon/pen/ERENZB .
After this fix, the re-added options are not highlighted anymore.