Highlight only works for the first typed letter

[skimi]

The highlight only highlights the first or first and second letterz (if you are fast) of the input text.
Afterward anything you type is ignored.

Also, if you copy paste a string in the input it will be highlighted completely but will ignore anything you type after that string.
This must be related to some kind of timing issue.

Steps to reproduce:

1. On http://selectize.github.io/selectize.js/ Email Contacts example
2. Type "brian"
3. Only "b" or "br" is highlighted

Expected result:
Brian should be highlighted in both the email and the name

Actual result:
Only "b" or "br" is highlighted

Might be related:
The highlight <span class="highlight"> gets wrapped inside other <span class="highlight"> at each new highlight instead of resetting the string.

[skimi]

Ok, I've debugged a bit more.

The bug is due to the way the highlight function splits the string to insert the <span class="highlight">. After the split, every letter is on its own line and is considered a full word by the function.

In newer version of the highlight function they have added a removeHighlight() function that solves the problem by reverting all highlighted strings to their original state.

I would simply update the highlight script to the last version but the last version has changed it's matching system and it does not pass the js strict mode so it can't be commited as is into selectize repo.

Anyway I've made a minimal commit where I've just updated selectize version to include their removeHighlight() and edited it to pass strict mode.

[0xbaigorria]

Hey guys!

I bet this is already fixed since Jonathan closed it, but I wanted to add to what Skimi pointed out, that a second issue is that since highlights don't get cleared, you end up with multiple <span>s wrapping the same or different highlighted letters. Check screenshot.

I'm using Safari Version 9.1.2 (11601.7.7) on OS X 10.11.6 (15G31).

[skimi]

Yep it'll be fixed in 0.12.3. Previous highlights will always get cleared before new ones are added.

[Larivact]

When will 0.12.3 be released? It's annoying to download the latest release only to figure out that the highlighting is completely broken. And now so for over a month, despite a fix existing for 26 days.

[joallard]

@Larivact If you need master bugfixes, then use master. Else the new release will come soon.

[imolorhe]

@joallard would I get the fix if I download the code in the master branch?

[joallard]

@imolorhe correct!

[imolorhe]

Yeah I figured it out later. I had to build it to get the changes. The
changes aren't already built into the dist folder in the master branch.

On Mon, Aug 22, 2016, 8:59 PM Jonathan Allard notifications@github.com
wrote:

@imolorhe https://github.com/imolorhe correct!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1098 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEZQj4iYAewnlmYDjHJpRzFRa5O8JlIrks5qif-vgaJpZM4JDJle
.

Regards,
Samuel
http://about.me/sirmuel

[Wardrop]

@skimi This ought to be re-opened. I've just built from master and the highlighting is still buggy. If you type something, and then backspace it, the highlighting for the first letter remains until you type something else.