more undefined

Author: rebornix

src/commands.ts

@@ -99,7 +99,7 @@ export function registerCommands(context: vscode.ExtensionContext, prManager: Pu
 			// Reset HEAD and then apply reverse diff
 			await vscode.commands.executeCommand('git.unstageAll');
 
-			if (vscode.workspace.rootPath === undefined) {
+			if (!vscode.workspace.rootPath) {
 				throw new Error('Current workspace root path is undefined.');
 			}
 

src/common/diffPositionMapping.ts

@@ -72,8 +72,8 @@ export function getPositionInDiff(comment: Comment, fileDiffHunks: DiffHunk[], i
 	return commentAbsolutePosition;
 }
 
-export function getLastDiffLine(prPatch: string): DiffLine | null {
-	let lastDiffLine = null;
+export function getLastDiffLine(prPatch: string): DiffLine | undefined {
+	let lastDiffLine = undefined;
 	let prDiffReader = parseDiffHunk(prPatch);
 	let prDiffIter = prDiffReader.next();
 
@@ -87,7 +87,7 @@ export function getLastDiffLine(prPatch: string): DiffLine | null {
 	return lastDiffLine;
 }
 
-export function getDiffLineByPosition(diffHunks: DiffHunk[], diffLineNumber: number): DiffLine | null {
+export function getDiffLineByPosition(diffHunks: DiffHunk[], diffLineNumber: number): DiffLine | undefined {
 	for (let i = 0; i < diffHunks.length; i++) {
 		let diffHunk = diffHunks[i];
 		for (let j = 0; j < diffHunk.diffLines.length; j++) {
@@ -97,7 +97,7 @@ export function getDiffLineByPosition(diffHunks: DiffHunk[], diffLineNumber: num
 		}
 	}
 
-	return null;
+	return undefined;
 }
 
 export function mapHeadLineToDiffHunkPosition(diffHunks: DiffHunk[], localDiff: string, line: number, isBase: boolean = false): number {

src/common/protocol.ts

@@ -97,7 +97,7 @@ export class Protocol {
 		let lastIndex = normalized.lastIndexOf('/');
 		let lastSegment = normalized.substr(lastIndex + 1);
 		if (lastSegment === '' || lastSegment === '/') {
-			return null;
+			return;
 		}
 
 		return lastSegment.replace(/\/$/, '').replace(/\.git$/, '');
@@ -114,12 +114,12 @@ export class Protocol {
 			return fragments[fragments.length - 2];
 		}
 
-		return null;
+		return;
 	}
 
-	normalizeUri(): vscode.Uri | null {
+	normalizeUri(): vscode.Uri | undefined {
 		if (this.type === ProtocolType.OTHER && !this.url) {
-			return null;
+			return;
 		}
 
 		if (this.type === ProtocolType.Local) {
@@ -134,11 +134,11 @@ export class Protocol {
 		try {
 			return vscode.Uri.parse(`${scheme}://${this.host.toLocaleLowerCase()}/${this.nameWithOwner.toLocaleLowerCase()}`);
 		} catch (e) {
-			return null;
+			return;
 		}
 	}
 
-	toString(): string | null {
+	toString(): string | undefined {
 		// based on Uri scheme for SSH https://tools.ietf.org/id/draft-salowey-secsh-uri-00.html#anchor1 and heuristics of how GitHub handles ssh url
 		// sshUri        = `ssh:`
 		//    - omitted
@@ -163,7 +163,7 @@ export class Protocol {
 			return normalizedUri.toString();
 		}
 
-		return null;
+		return;
 	}
 
 	update(change: { type?: ProtocolType; host?: string; owner?: string; repositoryName?: string; }): Protocol {

src/common/ssh.ts

@@ -68,18 +68,18 @@ export class Resolvers {
 	static current = Resolvers.default;
 }
 
-const parse = (url: string): Config | null => {
+const parse = (url: string): Config | undefined => {
 	const urlMatch = URL_SCHEME_RE.exec(url);
 	if (urlMatch) {
 		const [fullSchemePrefix, scheme] = urlMatch;
 		if (scheme === 'ssh') {
 			url = url.slice(fullSchemePrefix.length);
 		} else {
-			return null;
+			return;
 		}
 	}
 	const match = SSH_URL_RE.exec(url);
-	if (!match) { return null; }
+	if (!match) { return; }
 	const [, User, Host, path] = match;
 	return {User, Host, path};
 };

src/github/githubRepository.ts

@@ -30,7 +30,7 @@ export class GitHubRepository implements IGitHubRepository {
 	private _metadata: any;
 
 	public get hub(): GitHub {
-		if (this._hub === undefined) {
+		if (!this._hub) {
 			if (!this._initialized) {
 				throw new Error('Call ensure() before accessing this property.');
 			} else {

src/github/pullRequestOverview.ts

@@ -262,7 +262,7 @@ export class PullRequestOverviewPanel {
 			const comment = message.args.comment;
 			const regex = /```diff\n([\s\S]*)\n```/g;
 			const matches = regex.exec(comment.body);
-			if (vscode.workspace.rootPath === undefined) {
+			if (!vscode.workspace.rootPath) {
 				throw new Error('Current workspace rootpath is undefined.');
 			}
 			const tempFilePath = path.resolve(vscode.workspace.rootPath, '.git', `${comment.id}.diff`);

src/view/prChangesTreeDataProvider.ts

@@ -101,7 +101,7 @@ export class PullRequestChangesTreeDataProvider extends vscode.Disposable implem
 
 		if (fileChange) {
 			await this.reveal(fileChange, { focus: true, expand: 2 });
-			if (fileChange.command.arguments === undefined) {
+			if (!fileChange.command.arguments) {
 				return;
 			}
 			if (fileChange instanceof GitFileChangeNode) {

src/view/treeNodes/pullRequestNode.ts

@@ -28,22 +28,14 @@ export function providePRDocumentComments(
 	inDraftMode: boolean) {
 	const params = fromPRUri(document.uri);
 
-	if (!params) {
-		return undefined;
-	}
-
-	if (params.prNumber !== prNumber) {
-		return undefined;
+	if (!params || params.prNumber !== prNumber) {
+		return;
 	}
 
 	const isBase = params.isBase;
 	const fileChange = fileChanges.find(change => change.fileName === params.fileName);
-	if (!fileChange) {
-		return undefined;
-	}
-
-	if (fileChange instanceof RemoteFileChangeNode) {
-		return undefined;
+	if (!fileChange || fileChange instanceof RemoteFileChangeNode) {
+		return;
 	}
 
 	let commentingRanges: vscode.Range[] = [];
@@ -245,7 +237,7 @@ export class PRNode extends TreeNode {
 			const comments = await this._prManager.getPullRequestComments(this.pullRequestModel);
 			const data = await this._prManager.getPullRequestFileChangesInfo(this.pullRequestModel);
 			const mergeBase = this.pullRequestModel.mergeBase;
-			if (mergeBase === undefined) {
+			if (!mergeBase) {
 				return [];
 			}
 
@@ -334,7 +326,7 @@ export class PRNode extends TreeNode {
 
 		if (fileChange) {
 			await this.reveal(fileChange, { focus: true });
-			if (fileChange.command.arguments === undefined) {
+			if (!fileChange.command.arguments) {
 				return;
 			}
 			if (fileChange instanceof InMemFileChangeNode) {