Update consensus configs to be less strict #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipsu522
reviewed
Jan 13, 2023
app/params/config.go
Outdated
| config.Consensus.UnsafeVoteTimeoutOverride = 50 * time.Millisecond | ||
| config.Consensus.UnsafeVoteTimeoutDeltaOverride = 500 * time.Millisecond | ||
| config.Consensus.UnsafeCommitTimeoutOverride = 50 * time.Millisecond | ||
|
|
||
| config.Consensus.UnsafeCommitTimeoutOverride = 100 * time.Millisecond |
There was a problem hiding this comment.
can we keep this as 50ms? we can bump up if needed. This will add about 50ms to consensus if we make this change, and this is on top of waiting for 2/3 votes already
philipsu522
reviewed
Jan 13, 2023
app/params/config.go
Outdated
| @@ -93,11 +95,9 @@ func SetTendermintConfigs(config *tmcfg.Config) { | |||
| config.Consensus.GossipTransactionKeyOnly = true | |||
| config.Consensus.UnsafeProposeTimeoutOverride = 1 * time.Second | |||
There was a problem hiding this comment.
can we change this to 5 seconds? i have a theory that a lower value leads to a lot more rounds (more prevotes of nil) which makes consensus slow when we barely have 67%
philipsu522
approved these changes
Jan 13, 2023
|
BrandonWeng
added a commit
that referenced
this pull request
Jan 13, 2023
* done * done * done * Update config.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Sei-devnet-2 seeing a lot of validators miss blocks, turn off skip
UnsafeBypassCommitTimeoutOverrideand increase commit timeout to 100msDon't need to change TM as this directly overrides whatever is from the config.toml file
Testing performed to validate your change
local chain with timeout set to 5s, can see that each block height was very slow