Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parallelization test contracts & fixes #470

Merged
merged 7 commits into from
Jan 8, 2023
Merged

parallelization test contracts & fixes #470

merged 7 commits into from
Jan 8, 2023

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Dec 28, 2022 •
edited
Loading

Describe your changes and provide context

Add in contracts used for testing parallelization.

As made some fixes to dependencies in bank & dex message types

Testing performed to validate your change

tested by

  1. deploying the contracts to local chain
  2. register dependencies according to deps.json under each contract's directory
  3. add in logging before and after DeliverTx
  4. send multiple transactions in the same block (e.g. with async broadcast type) and observe the logs. If there are overlaps between logs for different transactions, we know that the transactions are running in parallel.

@codchen codchen force-pushed the tony-chen-test-prioritization branch from c083d38 to 76f711a Compare January 3, 2023 06:52
@codchen codchen changed the title parallelization test parallelization test contracts & fixes Jan 3, 2023
@codchen codchen requested review from udpatil and BrandonWeng January 3, 2023 07:02
@codchen codchen marked this pull request as ready for review January 3, 2023 07:03
BrandonWeng
BrandonWeng previously approved these changes Jan 3, 2023
View reviewed changes
udpatil
udpatil reviewed Jan 3, 2023
View reviewed changes
aclmapping/bank/mappings.go Outdated
IdentifierTemplate: hex.EncodeToString(authtypes.GlobalAccountNumberKey),
},
{
AccessType: sdkacltypes.AccessType_WRITE,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this mean that NO bank sends can be parallelized? Is there some check we can do before including this dependency so that we can retain some level of performance in the normal case for bank sends?

@BrandonWeng BrandonWeng dismissed their stale review January 4, 2023 18:00

see uday's comments

@codchen codchen force-pushed the tony-chen-test-prioritization branch from 4c1b360 to 84ff2fe Compare January 7, 2023 05:13
@github-actions
Copy link

github-actions bot commented Jan 7, 2023

Code Coverage

Package Line Rate Complexity Health
github.com/sei-protocol/sei-chain/aclmapping/bank 83% 0 ✔
github.com/sei-protocol/sei-chain/aclmapping/dex 100% 0 ✔
github.com/sei-protocol/sei-chain/aclmapping/oracle 100% 0 ✔
github.com/sei-protocol/sei-chain/aclmapping/staking 82% 0 ✔
github.com/sei-protocol/sei-chain/aclmapping/tokenfactory 96% 0 ✔
github.com/sei-protocol/sei-chain/aclmapping/utils 0% 0 ❌
github.com/sei-protocol/sei-chain/aclmapping/wasm 83% 0 ✔
github.com/sei-protocol/sei-chain/app 59% 0 ➖
github.com/sei-protocol/sei-chain/app/antedecorators 74% 0 ➖
github.com/sei-protocol/sei-chain/oracle/price-feeder/config 85% 0 ✔
github.com/sei-protocol/sei-chain/oracle/price-feeder/oracle 73% 0 ➖
github.com/sei-protocol/sei-chain/oracle/price-feeder/oracle/provider 48% 0 ❌
github.com/sei-protocol/sei-chain/oracle/price-feeder/router/v1 45% 0 ❌
github.com/sei-protocol/sei-chain/store/whitelist/cachemulti 100% 0 ✔
github.com/sei-protocol/sei-chain/store/whitelist/kv 100% 0 ✔
github.com/sei-protocol/sei-chain/store/whitelist/multi 100% 0 ✔
github.com/sei-protocol/sei-chain/utils 46% 0 ❌
github.com/sei-protocol/sei-chain/utils/datastructures 90% 0 ✔
github.com/sei-protocol/sei-chain/x/dex 58% 0 ➖
github.com/sei-protocol/sei-chain/x/dex/cache 86% 0 ✔
github.com/sei-protocol/sei-chain/x/dex/client/cli/query 23% 0 ❌
github.com/sei-protocol/sei-chain/x/dex/contract 51% 0 ➖
github.com/sei-protocol/sei-chain/x/dex/exchange 89% 0 ✔
github.com/sei-protocol/sei-chain/x/dex/keeper 67% 0 ➖
github.com/sei-protocol/sei-chain/x/dex/keeper/abci 30% 0 ❌
github.com/sei-protocol/sei-chain/x/dex/keeper/msgserver 78% 0 ✔
github.com/sei-protocol/sei-chain/x/dex/keeper/query 82% 0 ✔
github.com/sei-protocol/sei-chain/x/dex/migrations 87% 0 ✔
github.com/sei-protocol/sei-chain/x/dex/types 1% 0 ❌
github.com/sei-protocol/sei-chain/x/dex/types/utils 100% 0 ✔
github.com/sei-protocol/sei-chain/x/dex/types/wasm 83% 0 ✔
github.com/sei-protocol/sei-chain/x/epoch 11% 0 ❌
github.com/sei-protocol/sei-chain/x/epoch/keeper 66% 0 ➖
github.com/sei-protocol/sei-chain/x/epoch/types 2% 0 ❌
github.com/sei-protocol/sei-chain/x/mint 0% 0 ❌
github.com/sei-protocol/sei-chain/x/mint/keeper 75% 0 ➖
github.com/sei-protocol/sei-chain/x/mint/simulation 95% 0 ✔
github.com/sei-protocol/sei-chain/x/mint/types 2% 0 ❌
github.com/sei-protocol/sei-chain/x/nitro/client/cli 45% 0 ❌
github.com/sei-protocol/sei-chain/x/nitro/keeper 80% 0 ✔
github.com/sei-protocol/sei-chain/x/nitro/replay 63% 0 ➖
github.com/sei-protocol/sei-chain/x/oracle 64% 0 ➖
github.com/sei-protocol/sei-chain/x/oracle/keeper 82% 0 ✔
github.com/sei-protocol/sei-chain/x/oracle/simulation 18% 0 ❌
github.com/sei-protocol/sei-chain/x/oracle/types 3% 0 ❌
github.com/sei-protocol/sei-chain/x/tokenfactory/keeper 85% 0 ✔
github.com/sei-protocol/sei-chain/x/tokenfactory/types 2% 0 ❌
Summary 15% (5037 / 33912) 0 ❌

@codchen codchen merged commit 3b9e9cb into master Jan 8, 2023
BrandonWeng pushed a commit that referenced this pull request Jan 13, 2023
@codchen @BrandonWeng
parallelization test contracts & fixes (#470)
e4866bc 
* parallelization test

* fixes for issues found during testing

* remove artifacts

* rm

* rm

* fix tests

* ci
BrandonWeng added a commit that referenced this pull request Jan 13, 2023
@BrandonWeng @codchen
Cherry pick fix and consensus config (#487)
89fefc0 
* parallelization test contracts & fixes (#470)

* parallelization test

* fixes for issues found during testing

* remove artifacts

* rm

* rm

* fix tests

* ci

* Update consensus configs to be less strict (#484)

* done

* done

* done

* Update config.go

Co-authored-by: codchen <codchen03@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udpatil udpatil udpatil left review comments

@BrandonWeng BrandonWeng BrandonWeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codchen @udpatil @BrandonWeng