Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM] Merge balances on associate tx #1630

Merged
merged 6 commits into from
May 7, 2024
Merged

Conversation

stevenlanders
Copy link
Contributor

@stevenlanders stevenlanders commented May 6, 2024

Describe your changes and provide context

  • adds new test that requires merge balances
  • migrates balance from evm to sei when associating on sei tx

Testing performed to validate your change

  • integration test

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 61.46%. Comparing base (502a560) to head (d8bf2e1).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1630      +/-   ##
==========================================
- Coverage   61.48%   61.46%   -0.03%     
==========================================
  Files         366      366              
  Lines       26354    26360       +6     
==========================================
- Hits        16205    16203       -2     
- Misses       9069     9074       +5     
- Partials     1080     1083       +3     
Files Coverage Δ
x/evm/ante/preprocess.go 76.69% <47.36%> (-1.01%) ⬇️

... and 4 files with indirect coverage changes

@stevenlanders stevenlanders changed the title [EVM] Fix associated balance after lazy-associate from sei transaction [EVM] Fix balance after lazy-associate from sei tx May 6, 2024
@philipsu522 philipsu522 changed the title [EVM] Fix balance after lazy-associate from sei tx [EVM] Merge balances on associate tx May 6, 2024
@stevenlanders stevenlanders merged commit 22404d5 into main May 7, 2024
50 checks passed
@stevenlanders stevenlanders deleted the associate-balances branch May 7, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants