Oracle Precompile #1445
Merged
Oracle Precompile #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## seiv2 #1445 +/- ##
==========================================
- Coverage 62.87% 62.02% -0.85%
==========================================
Files 350 353 +3
Lines 23965 24379 +414
==========================================
+ Hits 15068 15122 +54
- Misses 8029 8382 +353
- Partials 868 875 +7
|
Kbhat1
commented
Mar 20, 2024
Kbhat1
commented
Mar 20, 2024
Kbhat1
commented
Mar 20, 2024
stevenlanders
approved these changes
Mar 21, 2024
jewei1997
reviewed
Mar 21, 2024
jewei1997
reviewed
Mar 21, 2024
|
|
||
| for (let i = 0; i < exchangeRatesLen; i++) { | ||
| expect(exchangeRatesJSON[i].denom).to.equal(exchangeRates[i].denom); | ||
| } |
There was a problem hiding this comment.
Should we check that the other values in oracle_exchange_rate are reasonable values?
There was a problem hiding this comment.
@jewei1997 yea, take a look at this comment above about this #1445 (comment)
jewei1997
reviewed
Mar 21, 2024
jewei1997
approved these changes
Mar 21, 2024
udpatil
pushed a commit
that referenced
this pull request
Mar 27, 2024
* Oracle Precompile * Update abi oracle * Update tests * Update tests * Update abi + tests * integration test query * Precompile integration tests * Update type * Add more loggign * lint * Add more checks * update tests
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Oracle Precompile * Update abi oracle * Update tests * Update tests * Update abi + tests * integration test query * Precompile integration tests * Update type * Add more loggign * lint * Add more checks * update tests
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Oracle Precompile * Update abi oracle * Update tests * Update tests * Update abi + tests * integration test query * Precompile integration tests * Update type * Add more loggign * lint * Add more checks * update tests
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Oracle Precompile * Update abi oracle * Update tests * Update tests * Update abi + tests * integration test query * Precompile integration tests * Update type * Add more loggign * lint * Add more checks * update tests
udpatil
pushed a commit
that referenced
this pull request
Apr 18, 2024
* Oracle Precompile * Update abi oracle * Update tests * Update tests * Update abi + tests * integration test query * Precompile integration tests * Update type * Add more loggign * lint * Add more checks * update tests
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
* Oracle Precompile * Update abi oracle * Update tests * Update tests * Update abi + tests * integration test query * Precompile integration tests * Update type * Add more loggign * lint * Add more checks * update tests
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
* Oracle Precompile * Update abi oracle * Update tests * Update tests * Update abi + tests * integration test query * Precompile integration tests * Update type * Add more loggign * lint * Add more checks * update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change