IP Allowlisting GA [DOC-986] #6892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for segment-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
gandhar-t
reviewed
Aug 2, 2024
| > Segment might add additional IP address ranges. Before adding additional ranges, Segment will send an email to all Workspace Owners notifying them of the update. | ||
|
|
||
| ### Supported destinations | ||
| Segment supports IP Allowlisting in all Classic and Actions destinations except for the following: |
There was a problem hiding this comment.
Classic and Actions destinations as these are internal names for categorization, so customers likely may not understand this.
Couple of suggestions to resolve (pls feel free to ignore if there are more elegant solutions)
- reword to All destinations in Catalog (link to the Catalog) except the following
- add links to Classic and Actions destinations
There was a problem hiding this comment.
I'll go with the first option! Good callout, thanks!
gandhar-t
reviewed
Aug 2, 2024
✅ Deploy Preview for segment-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pwseg
approved these changes
Aug 5, 2024
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added section to Destinations Overview page + notes on some pages about new IP Allowlisting functionality
Merge timing
On/before 8/7
Related issues (optional)