Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add optional prop "name" to RadioGroupOwnProps in index.d.ts #1666

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jfelege
Copy link

@jfelege jfelege commented Sep 16, 2023

Overview

While attempting to set name prop on the ; encountered a typing issue where name was not defined, however, based on the public docs/propTypes it should be allowed.

<RadioGroup
  name="is_private"
  ...
/>

The type definition changes might have been introduced with #1344.

Screenshots (if applicable)

Screenshot 2023-09-16 at 11 23 10 AM

Documentation

  • Updated Typescript types and/or component PropTypes
  • Added / modified component docs
  • Added / modified Storybook stories

@netlify
Copy link

netlify bot commented Sep 16, 2023

Deploy Preview for evergreen-storybook ready!

Name Link
🔨 Latest commit 4cc8780
🔍 Latest deploy log https://app.netlify.com/sites/evergreen-storybook/deploys/6505d708a072d8000871e9ad
😎 Deploy Preview https://deploy-preview-1666--evergreen-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant