This repository was archived by the owner on Sep 3, 2022. It is now read-only.
Drop @segment/canonical. Also uprade some libs #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanmikaelian
force-pushed
the
bryan/remove-segment-canonical
branch
2 times, most recently
from
788a00b to
619fb0c
Compare
bryanmikaelian
force-pushed
the
bryan/remove-segment-canonical
branch
from
619fb0c to
ad578fb
Compare
juliofarah
approved these changes
Sep 18, 2020
juliofarah
added a commit
that referenced
this pull request
Mar 19, 2021
This reverts commit d4d70e3.
hbrls
pushed a commit
to nice-fungal/analytics.js-core
that referenced
this pull request
Apr 16, 2021
hbrls
pushed a commit
to nice-fungal/analytics.js-core
that referenced
this pull request
May 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
@segment/canonicallibrary in favor ofdocument.querySelector. We also are upgrading some test libraries likesinon.Note: We can't use the latest version of sinon because sinon 2+ only supports IE11+
Test plan
Testing completed successfully using unit tests and writing new tests
Checklist