Skip to content

Performed fixup for url options, lifecycle updates, objc compatibility #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 14, 2025

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Jul 13, 2025

  • Fixed merge conflict for url options.
  • Verified willTerminate's recent wire-up was still appropriate.
  • Moved trackApplicationLifecycleEvents back to being a bool.
  • Fixed relevant examples

Copy link

codecov bot commented Jul 13, 2025

Codecov Report

Attention: Patch coverage is 20.37037% with 43 lines in your changes missing coverage. Please review.

Project coverage is 70.76%. Comparing base (f56df7e) to head (309b2d6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...t/Plugins/Platforms/Mac/macOSLifecycleEvents.swift 0.00% 36 Missing ⚠️
Sources/Segment/Configuration.swift 66.66% 5 Missing ⚠️
Sources/Segment/ObjC/ObjCConfiguration.swift 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (20.37%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage   70.76%   70.76%           
=======================================
  Files          49       49           
  Lines        4898     4902    +4     
=======================================
+ Hits         3466     3469    +3     
- Misses       1432     1433    +1     
Files with missing lines Coverage Δ
Sources/Segment/Startup.swift 94.73% <100.00%> (ø)
Sources/Segment/State.swift 97.36% <ø> (-0.04%) ⬇️
Sources/Segment/ObjC/ObjCConfiguration.swift 32.00% <0.00%> (ø)
Sources/Segment/Configuration.swift 74.57% <66.66%> (-3.52%) ⬇️
...t/Plugins/Platforms/Mac/macOSLifecycleEvents.swift 2.43% <0.00%> (+0.19%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsneed bsneed changed the title Performed mixup for url options, lifecycle updates, objc compatibility Performed fixup for url options, lifecycle updates, objc compatibility Jul 14, 2025
@bsneed bsneed merged commit 1ffaa0d into main Jul 14, 2025
10 of 11 checks passed
@bsneed bsneed deleted the bsneed/lifecycle branch July 14, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants