-
Notifications
You must be signed in to change notification settings - Fork 99
Performed fixup for url options, lifecycle updates, objc compatibility #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+201
−154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bsneed
commented
Jul 13, 2025
- Fixed merge conflict for url options.
- Verified willTerminate's recent wire-up was still appropriate.
- Moved trackApplicationLifecycleEvents back to being a bool.
- Fixed relevant examples
# Conflicts: # Sources/Segment/Plugins/Platforms/iOS/iOSLifecycleEvents.swift
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (20.37%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
=======================================
Coverage 70.76% 70.76%
=======================================
Files 49 49
Lines 4898 4902 +4
=======================================
+ Hits 3466 3469 +3
- Misses 1432 1433 +1
🚀 New features to boost your workflow:
|
didiergarcia
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.