Ensure events send out after being forked - #50
Merged
Conversation
Contributor
There was a problem hiding this comment.
I think we still need this so the thread gets properly GC'd: #27
Contributor
|
niiiiiiice! :D this looks really sweet. only concern that I have is if they do something like: analytics.init('secret')
analytics.track(...)
== FORK ==
analytics.track(...)since the thread might still be "alive" but not actually synced with the right "queue" properly when the memory is copied. if that case works, lgtm! |
travisjeffery
added a commit
that referenced
this pull request
May 14, 2014
Ensure events send out after being forked
|
So to clarify - does this mean unicorn, et al users no longer have to re-init analytics-ruby after forking? |
|
This is pretty amazing. You should blog about this solution. I think it's a great pattern for lots of background threading. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that the threads that the event requests are on run after their process has been forked.
For people using forking servers like unicorn and passenger, they no longer have to setup the sdk again with: