fix: The proxy URL is being altered in version 2.20.4, resulting in invalid URL #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenxi-zeng
requested changes
Mar 19, 2025
wenxi-zeng
reviewed
Mar 20, 2025
wenxi-zeng
reviewed
Mar 21, 2025
wenxi-zeng
approved these changes
Mar 24, 2025
| return getURL(baseURL, endpoint); | ||
| } catch (error) { | ||
| console.error('Error in getEndpoint:', error); | ||
| throw new Error('Invalid proxy url has been passed'); |
There was a problem hiding this comment.
in case of not throwing error, then should return default value
…oints() & getEndpointForSettings()
wenxi-zeng
approved these changes
Mar 26, 2025
|
🎉 This PR is included in version 2.20.5 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: The proxy URL is being altered in version 2.20.4, resulting in invalid URL