Skip to content

Fallback to the defaultSettings if cdn cannot be reached #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

niallzato
Copy link
Contributor

Fallback to the default Settings if the CDN cannot be reached. If the app is started with no Internet connection, this will result in an empty settings object:

data class Settings(
    var integrations: JsonObject = emptyJsonObject,
    var plan: JsonObject = emptyJsonObject,
    var edgeFunction: JsonObject = emptyJsonObject,
    var middlewareSettings: JsonObject = emptyJsonObject,
    var metrics: JsonObject = emptyJsonObject,
    var consentSettings: JsonObject = emptyJsonObject
) {

didiergarcia
didiergarcia previously approved these changes Oct 1, 2024
Copy link
Contributor

@didiergarcia didiergarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Going to do some testing.

@didiergarcia didiergarcia self-requested a review October 1, 2024 17:18
@didiergarcia didiergarcia merged commit d37d2d3 into main Oct 3, 2024
7 of 8 checks passed
@didiergarcia didiergarcia deleted the niall/default_fallback branch October 3, 2024 18:53
didiergarcia added a commit that referenced this pull request Jan 16, 2025
didiergarcia added a commit that referenced this pull request Jan 28, 2025
* Revert "Fallback to the defaultSettings if cdn cannot be reached (#231)"

This reverts commit d37d2d3.

* Update tests after reverting.

* add a sane default Settings object similar to swift.

* fix: use a sane default settings object in cases where we can't connect.

* fix: set DestinationPlugins to enabled by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants