-
Notifications
You must be signed in to change notification settings - Fork 292
destination-upgrade-analyzer: extract out API versions from code (batch 1) #3431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3431 +/- ##
==========================================
+ Coverage 79.95% 79.97% +0.01%
==========================================
Files 1223 1228 +5
Lines 22691 22706 +15
Branches 4504 4503 -1
==========================================
+ Hits 18143 18158 +15
Misses 3717 3717
Partials 831 831 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a centralized approach for managing API version constants across multiple destination integrations. The changes extract hardcoded API version strings into dedicated versioning-info.ts files, making version management more maintainable and consistent.
- Introduces
versioning-info.tsfiles for 5 destinations (aampe, aggregations-io, ambee, angler-ai, antavo) - Replaces hardcoded API version strings with imported constants
- Updates quote styles from escaped single quotes to double quotes in several field descriptions
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| antavo/versioning-info.ts | New file defining ANTAVO_API_VERSION constant |
| antavo/profile/index.ts | Updates API version usage and quote style in field descriptions |
| antavo/event/index.ts | Updates URL construction to use ANTAVO_API_VERSION constant |
| angler-ai/versioning-info.ts | New file defining ANGLER_AI_API_VERSION constant |
| angler-ai/routes.ts | Updates all endpoint functions to use ANGLER_AI_API_VERSION |
| ambee/versioning-info.ts | New file defining AMBEE_API_VERSION constant |
| ambee/subscribeUserToCampaign/index.ts | Updates to use AMBEE_API_VERSION with base URL constant |
| ambee/index.ts | Updates authentication test endpoint to use AMBEE_API_VERSION |
| aggregations-io/versioning-info.ts | New file defining AGGREGATIONS_IO_API_VERSION constant |
| aggregations-io/index.ts | Updates authentication endpoint to use AGGREGATIONS_IO_API_VERSION |
| aampe/versioning-info.ts | New file defining AAMPE_API_VERSION constant |
| aampe/constants.ts | Updates all region URL constants to use AAMPE_API_VERSION |
| } | ||
| } | ||
| }, | ||
| } |
Copilot
AI
Nov 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Removed trailing comma after the 'mobile_phone' property definition, which is inconsistent with JavaScript/TypeScript conventions that typically include trailing commas for better version control diffs.
| mobile_phone: { | ||
| '@path': '$.traits.mobile_phone' | ||
| } | ||
| } |
Copilot
AI
Nov 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Removed trailing comma after the data field's default object, which is inconsistent with the codebase's typical formatting that includes trailing commas.
| } | |
| }, |
This pull request introduces a standardized approach to API versioning across several destination integrations by extracting API version strings into dedicated constants and updating endpoint constructions to use these constants. This improves maintainability and consistency when updating or managing API versions in the future.
The most important changes are:
API Versioning Standardization
*_API_VERSION) in newversioning-info.tsfiles for each integration: Ambee, Antavo, Angler AI, AAMPE, and Aggregations.io, and updated all endpoint constructions to use these constants instead of hardcoded version strings. [1] [2] [3] [4] [5]Endpoint Construction Refactoring
Minor Consistency Improvements
These changes collectively make it easier to manage API versions and reduce the risk of errors when updating endpoints across multiple destinations.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'