Merged
Conversation
prayansh
approved these changes
Sep 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If products are passed as a null value it will cause a fatal exception in app. For example:
Analytics.with(this).track("Cart Viewed", new Properties()
.putValue("products", null));
Will throw the following exception:
2021-09-01 14:57:49.425 19542-19542/com.example.firebase E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.example.firebase, PID: 19542
java.lang.NullPointerException: Attempt to invoke interface method 'java.util.Iterator java.util.List.iterator()' on a null object reference
at com.segment.analytics.android.integrations.firebase.FirebaseIntegration.formatProducts(FirebaseIntegration.java:227)