Rearrange to expose driver as a lib #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sperand-io
commented
May 5, 2017
Dockerfile
Outdated
| # Additionally add a cron-like runner to run on an | ||
| # interval. | ||
| RUN go get -u github.com/segmentio/go-every | ||
| ADD . /go/src/github.com/segment-sources/postgres |
There was a problem hiding this comment.
no idea where i should be putting this. @tejasmanohar is there like a convention i should be using here?
There was a problem hiding this comment.
location is fine. didn't know ADD will mkdir for you... just docker build . -> docker run and it worked though!
sperand-io
commented
May 5, 2017
Dockerfile
Outdated
|
|
||
| # Additionally add a cron-like runner to run on an | ||
| # interval. | ||
| RUN go get -u github.com/segmentio/go-every |
There was a problem hiding this comment.
dont think this was actually being used?
There was a problem hiding this comment.
it's there in mongo source too. i'd keep the dep as is for this PR in case people are doing docker run --entrypoint=every postgres --... or something
|
|
this may be a record in terms of number of commits / LOC changed ratio. @tejasmanohar mind doing another quick review? |
tejasmanohar
reviewed
May 9, 2017
| ENTRYPOINT ["source-postgres"] |
tejasmanohar
approved these changes
May 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's likely folks will want to consume the driver separately so that they can write their own runners. in fact, we do :D (for bookkeeper etl)