-
-
Notifications
You must be signed in to change notification settings - Fork 552
feat: add jellyfin/emby quick connect authentication #2212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
777f0b7 to
025f6e3
Compare
|
wow, thanks a lot for this PR :D I've built an docker image with your changes. Creating a new account with new QuickConnect method works flawlessly if Enable New Jellyfin Sign-In is enabled :) However, QuickConnect functionality is missing from Linked Accounts settings when trying to link a Jellyfin Account. And since my Jellyfin users are using OIDC-based login for Jellyfin - and they therefore don't have a password they could enter there - linking their Jellyfin accounts is not possible without QuickConnect functionality.... Have you thought about adding QuickConnect there as well? EDIT: |
Good catch. I forgot about that. Will add.
This is out of scope of this PR. This functionality is already there in the oidc pr. |
Implements a quick connect authentication flow for jellyfin and emby servers. fix #1595
d9b8550 to
a93716e
Compare
…uick connect flow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.



Description
Adds support for Jellyfin/Emby Quick Connect authentication, providing users with an alternative login method. Jellyfin Quick Connect button is handled as a modal (see screenshots below).
How Has This Been Tested?
Screenshots / Logs (if applicable)
Login Page:

Quick Connect Modal:

Linked Accounts modal in User profile:

Linked Accounts quick connect modal:

Checklist:
pnpm buildpnpm i18n:extract