Skip to content

Conversation

@fallenbagel
Copy link
Collaborator

@fallenbagel fallenbagel commented Dec 8, 2025

Description

Adds support for Jellyfin/Emby Quick Connect authentication, providing users with an alternative login method. Jellyfin Quick Connect button is handled as a modal (see screenshots below).

How Has This Been Tested?

  • Tested Quick Connect flow with Jellyfin server
  • Tested Quick Connect flow with Emby server (Needs to be tested on emby)
  • Verified code expiration
  • Verified failed connections
  • Properly logs in the existing User

Screenshots / Logs (if applicable)

Login Page:
image

Quick Connect Modal:
image

Linked Accounts modal in User profile:
image

Linked Accounts quick connect modal:
image

Checklist:

  • I have read and followed the contribution guidelines.
  • Disclosed any use of AI (see our policy)
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

@fallenbagel fallenbagel requested a review from a team as a code owner December 8, 2025 20:28

This comment was marked as outdated.

@fallenbagel fallenbagel force-pushed the fallenbagel/feat-jellyfin-quick-connect branch from 777f0b7 to 025f6e3 Compare December 8, 2025 21:10
@v3DJG6GL
Copy link

v3DJG6GL commented Dec 9, 2025

wow, thanks a lot for this PR :D

I've built an docker image with your changes. Creating a new account with new QuickConnect method works flawlessly if Enable New Jellyfin Sign-In is enabled :)

However, QuickConnect functionality is missing from Linked Accounts settings when trying to link a Jellyfin Account. And since my Jellyfin users are using OIDC-based login for Jellyfin - and they therefore don't have a password they could enter there - linking their Jellyfin accounts is not possible without QuickConnect functionality....

Have you thought about adding QuickConnect there as well?

EDIT:
Additionally, an option to disable username/password-based Jellyfin logins would also be great. Currently, I can only completely disable the Login Method Jellyfin Sign-In, there is no option to select each other or both login methods.

@fallenbagel
Copy link
Collaborator Author

wow, thanks a lot for this PR :D

I've built an docker image with your changes. Creating a new account with new QuickConnect method works flawlessly if Enable New Jellyfin Sign-In is enabled :)

However, QuickConnect functionality is missing from Linked Accounts settings when trying to link a Jellyfin Account. And since my Jellyfin users are using OIDC-based login for Jellyfin - and they therefore don't have a password they could enter there - linking their Jellyfin accounts is not possible without QuickConnect functionality....

Have you thought about adding QuickConnect there as well?

Good catch. I forgot about that. Will add.

EDIT:
Additionally, an option to disable username/password-based Jellyfin logins would also be great. Currently, I can only completely disable the Login Method Jellyfin Sign-In, there is no option to select each other or both login methods.

This is out of scope of this PR. This functionality is already there in the oidc pr.

@v3DJG6GL
Copy link

v3DJG6GL commented Dec 10, 2025

Good catch. I forgot about that. Will add.

Great, thanks!

This is out of scope of this PR. This functionality is already there in the oidc pr.

I am not sure if I misunderstood you...
My current (jelly)seerr image actually has both functionalities included: OIDC and your QuickConnect PR.
I meant a functionality to enable/disable QuickConnect manually - something like this:
image

It's not that important to me, but I was thinking of people who, for example, have disabled the QuickConnect feature in Jellyfin anyway.

EDIT:
Just tested it. When I disable QuickConnect on Jellyfin and activate Jellyfin Sign-in on Jellyseerr, QuickConnect is still visible on Jellyseerr Sign-in page and I get this error message:
image

@fallenbagel
Copy link
Collaborator Author

I am not sure if I misunderstood you...
My current (jelly)seerr image actually has both functionalities included: OIDC and your QuickConnect PR.
I meant a functionality to enable/disable QuickConnect manually - something like this:
image

It's not that important to me, but I was thinking of people who, for example, have disabled the QuickConnect feature in Jellyfin anyway.

Ah. Still out of scope of this pr. That option has to be added in the oidc pr once this pr is merged.

@fallenbagel fallenbagel force-pushed the fallenbagel/feat-jellyfin-quick-connect branch from d9b8550 to a93716e Compare December 13, 2025 00:20

This comment was marked as outdated.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@v3DJG6GL
Copy link

I just tested your latest changes. Linking my account using QuickConnect works now.

One thing I just came across: I found a behaviour I am not sure whether that's intentional or not.

  1. Before linking Jellyseerr+Jellyfin accounts, my Jellyseerr account was created using OIDC (Authelia) and labeled as Local User.
  2. After linking Jellyseerr+Jellyfin accounts, my Jellyseerr account is labeled as Jellyfin User. At Linked Accounts I do have the possibility to remove my OIDC (Authelia) account but no possibility to remove my Jellyfin account:
image 3. For OIDC, the _Delete_ button is even visible when OIDC is the only linked account and the only authentication method. But that's probably something I need to raise at OIDC PR anyway... :)

@fallenbagel
Copy link
Collaborator Author

I just tested your latest changes. Linking my account using QuickConnect works now.

One thing I just came across: I found a behaviour I am not sure whether that's intentional or not.

  1. Before linking Jellyseerr+Jellyfin accounts, my Jellyseerr account was created using OIDC (Authelia) and labeled as Local User.
  2. After linking Jellyseerr+Jellyfin accounts, my Jellyseerr account is labeled as Jellyfin User. At Linked Accounts I do have the possibility to remove my OIDC (Authelia) account but no possibility to remove my Jellyfin account:
image 3. For OIDC, the _Delete_ button is even visible when OIDC is the only linked account and the only authentication method. But that's probably something I need to raise at OIDC PR anyway... :)

Removing jellyfin account is also an oidc pr thing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Login Method: Jellyfin QuickConnect

3 participants