-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple open issues #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs lots of changes still, especially regarding the imports. I'd also like to revert 94bbd87, for now.
This reverts commit 94bbd87.
I'm working on it. Will amend this PR in a bit. |
The way it is now, is ok. But... Honestly, I hate that It just doesn't make sense to pull these classes apart; they all conain cross references to each other. |
To be honest, I can not really understand why you hate the splitup. I can understand your problems with my mistakes (like mixing up the imports). I did many imports with the IDE and should have manually checked it which I did not, so I can understand your view there. I will fix this. However, splitting up the seeker types improves readability, as it no longer requires to search for the class in the complete file. The file |
@Belissimo-T Can we merge it? |
run_seekers
andrun_python
)linux
andwin32
)