Merged
Conversation
adityasaky
approved these changes
Sep 5, 2023
Member
There was a problem hiding this comment.
This looks good to me but I also haven't released sslib in the past.
For in-toto, I imagine we rework in-toto/in-toto#612 to go straight to the new CryptoSigner (and others), correct?
Edit: I think it might be a future change as we're already users of SSLibSigner and we want to start deprecating the ad-hoc parameters for signing key, GPG etc. I do see the tests have started using CryptoSigner so that PR should be unblocked with this release of sslib!
mnm678
approved these changes
Sep 5, 2023
Contributor
mnm678
left a comment
mnm678
left a comment
There was a problem hiding this comment.
I have also not done a previous release, so I might be missing something but this LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release new securesystemslib
I really wanted the new sigstore API (#630) in here but I guess that will be in the next release as sigstore still has blockers.