Remove obsolete gpg version utils #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukpueh
force-pushed
the
rm-gpg-version-utils
branch
from
7570085
to
100d3db
Compare
The gpg utility functions `is_version_fully_supported` and `get_version` were used in in-toto tests to case-handle different gpg versions. With in-toto/in-toto#190 this is no longer needed. See in-toto/in-toto@28ba993, in-toto/in-toto@c3a40b8. To reduce the API surface and maintenance burden this commit removes those functions. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
lukpueh
force-pushed
the
rm-gpg-version-utils
branch
from
100d3db
to
b0e9579
Compare
jku
approved these changes
Feb 10, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gpg utility functions
is_version_fully_supportedandget_versionwere used in in-toto tests to case-handle different gpg versions. With in-toto/in-toto#190 this is no longer needed.See in-toto/in-toto@28ba993, in-toto/in-toto@c3a40b8.
To reduce the API surface and maintenance burden this commit removes those functions.