Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use hatchling, don't use vcs integration #484

Merged
merged 3 commits into from
Dec 14, 2022
Merged

build: use hatchling, don't use vcs integration #484

merged 3 commits into from
Dec 14, 2022

Conversation

jku
Copy link
Collaborator

@jku jku commented Dec 14, 2022 •
edited
Loading

  • removes build dependencies
  • makes securesystemslib build more like the one in python-tuf
  • makes pip install git+https://github.com/secure-systems-lab/securesystemslib.git work again
  • requires setting version in __init__.py

Fixes #483

@jku
build: Use hatchling
c6454bd 
Use hatcling instead of setuptools: This makes securesystemslib similar
to python-tuf and hopefully gives us reproducible builds.
 * Use VCS integration for version number
 * Limit the files included in source distribution (mostly to prevent
   unrelated files from root directory from getting included)
@jku
build: Disable VCS integration
7243240 
Having unique version numbers from git describe during development is
nice... but it also breaks installing from git:
  pypa/setuptools-scm#449
(hatch-vcs uses setuptools_scm internally)

Removing hatch-vcs removes multiple indirect build dependencies so
seems like a good idea from that POV as well.
lukpueh
lukpueh approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@lukpueh lukpueh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Jussi! I tried this locally and it works as expected. I also looked into sdist and it includes everything we want.

Moving from setuptools to hatchling obviates the need for MANIFEST.in. Want to remove it?

@lukpueh lukpueh merged commit eb811ee into secure-systems-lab:master Dec 14, 2022
@ofek ofek mentioned this pull request Dec 15, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukpueh lukpueh lukpueh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build: Use hatchling (or get rid of setuptools_scm anyway)
2 participants
@jku @lukpueh