Quick round of CI improvements #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the new Python 3.11 release and use it for the specialised environments (no-gpg, pure Python, etc). Signed-off-by: Joshua Lock <jlock@vmware.com>
Run specialised builds (python-only and lint) on the latest version of the interpreter. Signed-off-by: Joshua Lock <jlock@vmware.com>
Update the actions we use to the most recent release and specify the version we want by digest, not by major version tag. This will allow greater determinism in CI runs and allow dependabot to update the actions for us. Signed-off-by: Joshua Lock <jlock@vmware.com>
GitHub have changed the way state is saved, environment files are the new preferred mechanism and set-output will soon be disabled. https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ Signed-off-by: Joshua Lock <jlock@vmware.com>
Drop all permissions, which will require any actions that need elevated permissions in future explicity add them. Signed-off-by: Joshua Lock <jlock@vmware.com>
jku
approved these changes
Nov 16, 2022
.github/workflows/ci.yml
Outdated
Comment on lines
43
to
45
| - name: Find pip cache dir | ||
| id: pip-cache | ||
| run: echo "::set-output name=dir::$(pip cache dir)" | ||
| run: echo "dir=$(pip cache dir)" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Nit: this step and the next one could be removed: setup-python now supports pip cache using with-arguments:
cache: 'pip'
cache-dependency-path: 'requirements*.txt'
There was a problem hiding this comment.
Oh, nice. Thanks for pointing this out! I just pushed an extra patch to make this change.
Simplify the workflow by specifying caching though setup-python's with-arguments. Signed-off-by: Joshua Lock <jlock@vmware.com>
joshuagl
force-pushed
the
joshuagl/ci
branch
from
658ac77
to
fb06b51
Compare
joshuagl
commented
Nov 16, 2022
Comment on lines
-24
to
+27
| toxenv: purepy38 | ||
| - python-version: 3.8 | ||
| toxenv: purepy311 | ||
| - python-version: "3.11" | ||
| os: ubuntu-latest | ||
| toxenv: py38-no-gpg | ||
| - python-version: 3.8 | ||
| toxenv: py311-no-gpg |
There was a problem hiding this comment.
These changes result in the name of the 'check' changing and therefore breaking our branch protection policy.
jku
approved these changes
Nov 18, 2022
Confirm that the jobs pass under their new names. Will update settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #455
Description of the changes being introduced by the pull request:
set-outputcommandPlease verify and check that the pull request fulfils the following requirements: