#4324 sort indices before splits #4347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akleshchev
reviewed
Jul 8, 2025
|
|
||
| // remap 32 bit into multiple 16 bit ones | ||
| std::vector<U32> remap(faceVertices.size()); | ||
| size_t vertex_count = meshopt_generateVertexRemap(&remap[0], &indices_32[0], indices_32.size(), &faceVertices[0], faceVertices.size(), sizeof(LLVolumeFace::VertexData)); |
There was a problem hiding this comment.
Please, consider leaving a comment like 'generateVertexRemap attempts to leave no gaps in the resulting sequence which should reduce amount of dupplicated indices after spliting'
There was a problem hiding this comment.
Agree, I'll add a comment.
akleshchev
reviewed
Jul 8, 2025
indra/newview/gltf/llgltfloader.cpp
Outdated
| std::vector<U32> optimized_indices(indices_32.size()); | ||
| meshopt_remapIndexBuffer(&optimized_indices[0], &indices_32[0], indices_32.size(), &remap[0]); | ||
|
|
||
| // Sort indices to improve mesh splits |
There was a problem hiding this comment.
Yes, it actually reorders indices.
There was a problem hiding this comment.
I know that it reorders, but does it apply distance or topology based sorting?
akleshchev
approved these changes
Jul 8, 2025
marchcat
approved these changes
Jul 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use mesh optimizer to sort indices by vertex order to improve splits.