Skip to content

Fix bit logic mistake in PRIM_MEDIA_FIRST_CLICK_INTERACT work #4311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

WolfGangS
Copy link
Contributor

@WolfGangS WolfGangS commented Jun 28, 2025

Another bug slipped in with the PRIM_MEDIA_FIRST_CLICK_INTERACT work

The bit field check wasn't correct

Currently if any option but none is selected ALL objects receive first clicks.

…turning 'true' on the ANY check for every enabled option
@github-actions github-actions bot added the c/cpp label Jun 28, 2025
@Ansariel
Copy link
Contributor

See my comments here: 2fdca60

@WolfGangS
Copy link
Contributor Author

Replied - I think all have been addressed.

I agree that the dropdown isn't the right way to show this kind of configurable option, but given it's current existence and order the values are correct.

@Ansariel
Copy link
Contributor

@Geenz
Copy link
Collaborator

Geenz commented Jun 30, 2025

@Ansariel @WolfGangS UX aside - how are the two of you feeling about the state of this PR?

@WolfGangS
Copy link
Contributor Author

It's small and required, the bug fix is needed for the feature to work right at all.

The enum switch just makes it less difficult to think about.

@Ansariel
Copy link
Contributor

Ansariel commented Jul 1, 2025

@Ansariel @WolfGangS UX aside - how are the two of you feeling about the state of this PR?

It's okay - I optimized the UI in Firestorm already. 😂

@bennettgoble
Copy link
Member

@WolfGangS thanks for the fix. Could you create a bug report with the repro steps so that we can have QA verify the fix in later builds?

@WolfGangS
Copy link
Contributor Author

@bennettgoble

Issue filed as bug here #4330 with reproduction steps

@akleshchev akleshchev requested review from Geenz and marchcat July 2, 2025 19:43
@bennettgoble bennettgoble merged commit de73d0f into secondlife:develop Jul 2, 2025
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2025
@bennettgoble bennettgoble linked an issue Jul 2, 2025 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media First click interact doesnt respect setting correctly
5 participants