#3758 initial chat mention support#3943
Merged
maxim-productengine merged 9 commits intorelease/2025.04from Apr 25, 2025
Merged
Conversation
maxim-productengine
force-pushed
the
maxim/2025.04-chat-mention
branch
from
fe05576 to
9127311
Compare
maxim-productengine
force-pushed
the
maxim/2025.04-chat-mention
branch
from
9127311 to
3e46d70
Compare
maxim-productengine
changed the title
akleshchev
reviewed
Apr 25, 2025
indra/llui/llchatmentionhelper.h
Outdated
| public: | ||
|
|
||
| bool isActive(const LLUICtrl* ctrl) const; | ||
| bool isCursorInNameMention(const LLWString& wtext, S32 cursor_pos, S32* mention_start_pos = nullptr); |
akleshchev
reviewed
Apr 25, 2025
indra/llui/llurlentry.h
Outdated
|
|
||
| #include "llavatarname.h" | ||
| #include "llhost.h" // for resolving parcel name by parcel id | ||
| #include "llurlmatch.h" |
Contributor
There was a problem hiding this comment.
Feels like EUnderlineLink should be elsewhere, doesn't seem related to urlmatch.
Contributor
Author
There was a problem hiding this comment.
Where do you think it fits better?
Contributor
There was a problem hiding this comment.
It can be argued that it's a style, so perhaps llstyle.h?
akleshchev
approved these changes
Apr 25, 2025
marchcat
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of basic chat mention feature.
Further improvements will be needed like: