Skip to content

[DO NOT MERGE] WIP Maint C #3895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 155 commits into from
Closed

[DO NOT MERGE] WIP Maint C #3895

wants to merge 155 commits into from

Conversation

marchcat
Copy link
Contributor

@marchcat marchcat commented Apr 10, 2025

Warning

Work in progress, do not merge!

Currently based on main.
Will be retargeted to 2025.04 or 2025.05 once ready.

akleshchev and others added 30 commits April 9, 2024 15:29
instead of having a 10 second delay to 'confirm' activity
Default value should be selected for replacement
# Conflicts:
#	indra/newview/skins/default/xui/en/floater_inventory_item_properties.xml
Release (Maint W) -> Maint C merge
1. onClear should clear file even if in 'don't log' state.
2. When chat isn't logging, check presence of old log by checking file.
This file is no longer used.
Drop python version from matrix configuration as it's always 3.11.
Move towards packaging artifacts with xz, which offers higher compression ratios and faster decode time.
On viewer shutdown
1. Instead of handling potential WM_* messages viewer is no longer
equiped to handle drop window's pointer and expect only WM_DESTROY
2. Detach thread and let it do its own thing, thread will delete itself
3. Reverts commit 1161262

Reason for the change: window was closing too early (as son as "LLApp"
status changes) without proper cleanup
1. Switched 'inspect' to thumbnails to minimalize differences
2. Reporting larger area to bump priority
3. Change scaling behavior. Old mechanics worked fine for icons that
were scaled down from large images to ~32, but for thumbnails it can
result in 256 image scaling down to ~200 before being scaled up to UI's
scale (scale factor), causing extra loss of quality.
Standard and scaled textures couldn't share workers and if one finished
a request, second one failed to start a new one.
Release (Maint YZ) -> Maint C merge
To not acuse confusion with favorites
marchcat and others added 16 commits April 10, 2025 23:34
* Restore changes from 2194777 to llwindow/llwindowwin32.cpp
* Restore changes from 3758618 to newview/llinspecttexture.cpp
* Fix apparent merge error in LLInventoryPanel::itemChanged
* Restore changes from 1eeecfa in newview/llpaneloutfitsinventory.h
* Restore changes from b9633c1 in newview/llpaneloutfitsinventory.h & newview/llpanelwearing.cpp
* Restore changes from f660f1f in newview/llviewertexture.cpp
* Restore changes from b9633c1 & 98f7d73 in newview/lloutfitgallery.cpp and newview/lloutfitslist.cpp
* Replace changes from 2372944 with current implementation in develop branch
* Fix more broken changes in LLViewerTexture::saveRawImage
* Restore the changes in LLMath both from develop and maint-c
* Fix all kind of other merge errors

# Conflicts:
#	indra/llmath/v2math.h
#	indra/llmath/v3math.h
#	indra/llui/llfolderviewitem.cpp
#	indra/llwindow/llwindowwin32.cpp
#	indra/newview/llfloaterobjectweights.h
#	indra/newview/lloutfitgallery.cpp
#	indra/newview/lloutfitslist.cpp
#	indra/newview/llsidepaneliteminfo.cpp
#	indra/newview/llvoavatar.cpp
# Conflicts:
#	indra/newview/llagent.cpp
* Re-apply changes from a620e58
* Fix duplicate code resulting from 826236f

# Conflicts:
#	indra/llwindow/llwindowwin32.cpp
# Conflicts:
#	indra/llui/llfolderviewitem.cpp
# Conflicts:
#	indra/newview/skins/default/xui/en/floater_preferences_graphics_advanced.xml
…y panel in List view; update persistence of new settings
@marchcat
Copy link
Contributor Author

@marchcat
Copy link
Contributor Author

Testing revealed the following crashes:
#3379
#3900

marchcat and others added 3 commits April 12, 2025 06:20
Key improvements:
1. Better error handling for thread detachment
2. More careful sequencing of operations
3. Ensuring the window is hidden before proceeding with other shutdown steps
4. Proper checking of thread joinability before detaching
@marchcat
Copy link
Contributor Author

The crashes should be addressed now.

Test build: https://github.com/secondlife/viewer/releases/tag/Second_Life_Test%231f17536-maint-c

akleshchev and others added 3 commits April 15, 2025 00:34
# Conflicts:
#	indra/llcommon/lldate.h
#	indra/newview/llappviewer.cpp
#	indra/newview/llinventorybridge.cpp
#	indra/newview/llmaterialeditor.cpp
#	indra/newview/llviewerparceloverlay.cpp
#	indra/newview/llvoavatar.cpp
@marchcat marchcat mentioned this pull request Apr 15, 2025
@marchcat
Copy link
Contributor Author

Created release/2025.05 from this branch. PR #3913

@marchcat marchcat closed this Apr 15, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2025
@marchcat marchcat deleted the marchcat/maint-c-restore branch April 15, 2025 19:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backport maint-c into 2025.05
10 participants